[SYCL][clang] Apply default arg suppression for template of templates #20880
Conversation
The SuppressDefaultTemplateArguments is a printing policy argument local to intel/llvm, but is currently only applied to basic templates. This commit applies the suppression of default arguments to template of templates cases as well. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
There was a problem hiding this comment.
Huh? I thought we fixed it somewhere already during the pulldown, right @schittir , @jsji , @premanandrao ?
|
@intel/dpcpp-cfe-reviewers friendly ping for review |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This was fixed in xmain-web in order to resolve a pulldown conflict, which migrated to xmain but not in the other direction, to intel/llvm. |
Ok, thanks! That should've been backported to intel/llvm as well so people don't waste time. |
Yes, the problem is that we were not testing the benchmark that exposed the failures in intel/llvm, so we forgot to backport. My bad, I did not follow up closely after the fix was merged. |
|
@intel/llvm-gatekeepers this can be merged |
6 participants
The SuppressDefaultTemplateArguments is a printing policy argument local to intel/llvm, but is currently only applied to basic templates. This commit applies the suppression of default arguments to template of templates cases as well.