Skip to content

[SYCL][clang] Apply default arg suppression for template of templates #20880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarnex merged 1 commit into from
Dec 12, 2025
Merged

[SYCL][clang] Apply default arg suppression for template of templates #20880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/AST/DeclPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1927,7 +1927,8 @@ void DeclPrinter::VisitNonTypeTemplateParmDecl(
void DeclPrinter::VisitTemplateTemplateParmDecl(
const TemplateTemplateParmDecl *TTPD) {
VisitTemplateDecl(TTPD);
if (TTPD->hasDefaultArgument() && !TTPD->defaultArgumentWasInherited()) {
if (TTPD->hasDefaultArgument() && !Policy.SuppressDefaultTemplateArguments &&
!TTPD->defaultArgumentWasInherited()) {
Out << " = ";
TTPD->getDefaultArgument().getArgument().print(Policy, Out,
/*IncludeType=*/false);
Expand Down
11 changes: 6 additions & 5 deletions clang/test/CodeGenSYCL/integration_header.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
//
// CHECK: // Forward declarations of templated kernel function types:
// CHECK: class first_kernel;
// CHECK-NEXT: template <typename T> struct point;
// CHECK-NEXT: namespace second_namespace {
// CHECK-NEXT: template <typename T> class second_kernel;
// CHECK-NEXT: template <typename T, template <typename> typename U> class second_kernel;
// CHECK-NEXT: }
// CHECK-NEXT: namespace template_arg_ns {
// CHECK-NEXT: template <int DimX> struct namespaced_arg;
Expand All @@ -17,7 +18,7 @@
// CHECK: static constexpr
// CHECK-NEXT: const char* const kernel_names[] = {
// CHECK-NEXT: "_ZTSZ4mainE12first_kernel",
// CHECK-NEXT: "_ZTSN16second_namespace13second_kernelIcEE",
// CHECK-NEXT: "_ZTSN16second_namespace13second_kernelIc5pointEE",
// CHECK-NEXT: "_ZTS13fourth_kernelIJN15template_arg_ns14namespaced_argILi1EEEEE"
// CHECK-NEXT: "_ZTSZ4mainE16accessor_in_base"
// CHECK-NEXT: "_ZTSZ4mainE15annotated_types"
Expand All @@ -36,7 +37,7 @@
// CHECK-NEXT: { kernel_param_kind_t::kind_accessor, 6112, 24 },
// CHECK-NEXT: { kernel_param_kind_t::kind_sampler, 8, 40 },
// CHECK-EMPTY:
// CHECK-NEXT: //--- _ZTSN16second_namespace13second_kernelIcEE
// CHECK-NEXT: //--- _ZTSN16second_namespace13second_kernelIc5pointEE
// CHECK-NEXT: { kernel_param_kind_t::kind_std_layout, 4, 0 },
// CHECK-NEXT: { kernel_param_kind_t::kind_accessor, 6112, 4 },
// CHECK-NEXT: { kernel_param_kind_t::kind_sampler, 8, 16 },
Expand Down Expand Up @@ -66,7 +67,7 @@
// CHECK-NEXT: };
//
// CHECK: template <> struct KernelInfo<first_kernel> {
// CHECK: template <> struct KernelInfo<::second_namespace::second_kernel<char>> {
// CHECK: template <> struct KernelInfo<::second_namespace::second_kernel<char, point>> {
// CHECK: template <> struct KernelInfo<::fourth_kernel<::template_arg_ns::namespaced_arg<1>>> {

#include "Inputs/sycl.hpp"
Expand All @@ -79,7 +80,7 @@ struct x {};
template <typename T>
struct point {};
namespace second_namespace {
template <typename T = int>
template <typename T = int, template <typename> typename U = point>
class second_kernel;
}

Expand Down