-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Replaces torch.norm with torch.linalg.norm for consistency #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fan-ziqi
wants to merge
7
commits into
isaac-sim:main
Choose a base branch
from
fan-ziqi:devel-norm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtigue-bdai
reviewed
Sep 8, 2025
jtigue-bdai
reviewed
Sep 8, 2025
jtigue-bdai
reviewed
Sep 8, 2025
jtigue-bdai
reviewed
Sep 8, 2025
Fixed all incorrect replacements |
@Mayankm96 @kellyguo11 some tests are failing even though getting all green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
torch.norm
is deprecated and may be removed in a future PyTorch release (document here), Standardizes tensor norm calculations throughout the codebase by switching fromtorch.norm
totorch.linalg.norm
. This ensures compatibility with current PyTorch best practices and improves clarity for future maintenance.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there