Skip to content

Conversation

fan-ziqi
Copy link
Contributor

@fan-ziqi fan-ziqi commented Sep 8, 2025

Description

Since torch.norm is deprecated and may be removed in a future PyTorch release (document here), Standardizes tensor norm calculations throughout the codebase by switching from torch.norm to torch.linalg.norm. This ensures compatibility with current PyTorch best practices and improves clarity for future maintenance.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@fan-ziqi
Copy link
Contributor Author

fan-ziqi commented Sep 8, 2025

Fixed all incorrect replacements

@jtigue-bdai
Copy link
Collaborator

@Mayankm96 @kellyguo11 some tests are failing even though getting all green

@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Sep 11, 2025
@Mayankm96 Mayankm96 added the bug Something isn't working label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working isaac-lab Related to Isaac Lab team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants