-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Renames joint dynamic and static friction variables #3461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Renames joint dynamic and static friction variables #3461
Conversation
Signed-off-by: matthewtrepte <[email protected]>
…IsaacLab into mtrepte/rename_joint_vars
Signed-off-by: matthewtrepte <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good. the main thing is the use of torque. In most cases it will be torque but for prismatic joints it will be a force. Effort is a more general term but you can add clarification that effort (force or torque).
source/isaaclab/isaaclab/assets/articulation/articulation_data.py
Outdated
Show resolved
Hide resolved
source/isaaclab/isaaclab/assets/articulation/articulation_data.py
Outdated
Show resolved
Hide resolved
source/isaaclab/isaaclab/assets/articulation/articulation_data.py
Outdated
Show resolved
Hide resolved
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: matthewtrepte <[email protected]>
Signed-off-by: matthewtrepte <[email protected]>
""" | ||
|
||
# TODO(mtrepte): do these friction vars need to be renamed as well? | ||
friction: dict[str, float] | float | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can mark this as deprecated as well and keep it for now for backward support for 4.5 where it's still a coefficient. we can update the docstring to mention in 4.5 it's coeff, and in 5.0+ it's effort. then, we can also create a new static_friction parameter for the new API that will be effort. @jtigue-bdai do you think that would make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, though please check again
Let's merge this after #3318 is done since that one has been hanging for a while. |
Description
Rename misnamed joint coefficient variables in Articulation as the new joint friction APIs are forces/torques and not coefficients.
In Articulation
joint_friction_coeff
tojoint_static_friction_effort
joint_dynamic_friction_coeff
tojoint_dynamic_friction_effort
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there