Fixes contact threshold when activating contact sensor #3498
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Mayankm96
reviewed
Sep 18, 2025
| sem.GetSemanticDataAttr().Set(semantic_value) | ||
| # activate rigid body contact sensors | ||
| if hasattr(cfg, "activate_contact_sensors") and cfg.activate_contact_sensors: | ||
| schemas.activate_contact_sensors(prim_paths[0], cfg.activate_contact_sensors) |
There was a problem hiding this comment.
Hmm this definitely changes behaviors. Can we update the changelog and extension.toml for this? We'll need to report this as a breaking change I feel.
There was a problem hiding this comment.
ya I agree it'll be a breaking change, but hopefully the new behavior makes it more intuitive. we can also keep this change out of the 2.3 release for now to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were incorrectly passing in the activate contact sensor boolean as the threshold when setting up the contact sensor API, which caused the sensor threshold to always be 1 when the sensor is activated. The desired behavior should be defaulting to 0 threshold.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there