-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Refactor] istio.io security concept page - Authz #10164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
b2c4dd1
to
c3dab24
Compare
c3dab24
to
36db2c0
Compare
36db2c0
to
8733eb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I
|
||
#### Value matching | ||
In the [Security Policy Examples](docs/ops/configuration/security/security-policy-examples/), we introduce more policy use cases like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should make sure the new content is ready when deleting it from the concept page. You could do it in a single PR that adds the new content in example/task/reference page while deleting it from concept page.
Otherwise there is chance that some contents are removed in this PR but forget to be added in other places, and more importantly, separating the change will make it harder to review and compare the newly added content to the old one, and it puts the preminary.istio.io in an incomplete status until all changes are merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion. Yes, the changes to the authz part will be in the same PR. But let's first have consensus of how will the concept page look like. The concept page changes will be finished in the 1st commit, and I will commit the tasks/reference changes in this PR as a different commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we reach agreement on the concept page, @justinpettit will work with me on finding a section that fits for the delete content. In this way, we can greatly reduce moving the content around. Thanks~
@xulingqing: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xulingqing: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xulingqing and @justinpettit, any interest in finishing this off?
Preview Link: https://deploy-preview-10164--preliminary-istio.netlify.app/latest/docs/concepts/security/#authorization
Main Changes:
Authorization architecture
to Authorization introduction partImplicit enablement
toPolicy Precedence
with brief introductionPolicy Target
Value matching
Exclusion matching
as a Policy Matching section with concept rewriteallow-all
policy, Custom conditions, unauthenticated identity, authz on plain TCP protocols to operation/config/security