Add initializing virtual workspace provider #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
dco-signoff: yes
cnvergence
force-pushed
the
init-vw-provider
branch
from
f5f978d to
c546304
Compare
cnvergence
force-pushed
the
init-vw-provider
branch
from
532b2c1 to
eb2654b
Compare
kcp-ci-bot
added
size/XXL
cnvergence
force-pushed
the
init-vw-provider
branch
from
db664a7 to
b896fdf
Compare
kcp-ci-bot
added
size/XL
cnvergence
force-pushed
the
init-vw-provider
branch
from
1291f52 to
ba11d92
Compare
cnvergence
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
embik
requested changes
Jun 26, 2025
Member
embik
left a comment
embik
left a comment
There was a problem hiding this comment.
Haven't done a deep dive into the code, just some changes regarding code structure.
kcp-ci-bot
added
release-note
embik
requested changes
Jun 27, 2025
cnvergence
added
the
do-not-merge/hold
kcp-ci-bot
added
do-not-merge/work-in-progress
cnvergence
force-pushed
the
init-vw-provider
branch
from
96e48eb to
116e31f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new initializingworkspaces virtual workspace provider for KCP, allowing controllers to reconcile workspaces in the initializing phase. The provider shares common functionality with the existing apiexport provider by refactoring cache implementation into a shared internal/cache package.
Key changes:
- Extracts cache implementation from
apiexportpackage tointernal/cachefor reuse - Adds new
initializingworkspacesprovider implementation - Updates function visibility to support shared usage across packages
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
initializingworkspaces/provider.go |
Core provider implementation for initializing workspaces |
internal/cache/*.go |
Refactored cache implementation moved from apiexport package |
test/e2e/initializingworkspaces_test.go |
E2E test for the new provider |
examples/initializingworkspaces/ |
Example controller and documentation |
apiexport/provider.go |
Updated imports to use refactored cache package |
cnvergence
force-pushed
the
init-vw-provider
branch
4 times, most recently
from
c085cfa to
65e9d46
Compare
cnvergence
force-pushed
the
init-vw-provider
branch
2 times, most recently
from
133ed03 to
569f3e1
Compare
embik
reviewed
Aug 4, 2025
cnvergence
force-pushed
the
init-vw-provider
branch
from
569f3e1 to
3d9bee3
Compare
kcp-ci-bot
added
the
needs-rebase
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] add example on initializing workspaces Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] add initvw example controller Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] update code structure and fix linters Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] add specific cluster and start individual cache Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] intercept clusterName with event handler Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] implement routed client to use wildcard cache fetching LogicalClusters Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
…pedCluster func Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] Address review comments and clean up old code Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
cnvergence
force-pushed
the
init-vw-provider
branch
from
3d9bee3 to
de20df4
Compare
kcp-ci-bot
removed
the
needs-rebase
Contributor
|
LGTM label has been added. Git tree hash: 7eb240d1dc12301d87d16a6966c505621a60f57a
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the provider for initializingworkspaces, sharing the code with
apiexportprovider.Added example of controller and e2e test.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #17
Release Notes