Skip to content

Conversation

@DolevNe
Copy link
Contributor

@DolevNe DolevNe commented Aug 18, 2025

Closes #5255

📑 Description

the function that gets the alert by fingerprint uses a function that fetches the last 1000 alerts (get_last_alerts)
the route should use the function get_last_alerts_by_fingerprints

✅ Checks

  • My pull request adheres to the code style of this project
  • All the tests have passed

@vercel
Copy link

vercel bot commented Aug 18, 2025

@DolevNe is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. API API related issues Bug Something isn't working labels Aug 18, 2025
@vercel
Copy link

vercel bot commented Aug 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
keep Ignored Ignored Aug 20, 2025 1:23pm

@talboren
Copy link
Member

@DolevNe can you add a quick unit test to make sure we don't fall here again? also - what element in the ui uses this api? lets make sure it works properly too

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.73%. Comparing base (74e4c9f) to head (ac2e430).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5258   +/-   ##
=======================================
  Coverage   30.73%   30.73%           
=======================================
  Files         101      101           
  Lines       11494    11494           
=======================================
  Hits         3533     3533           
  Misses       7961     7961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 20, 2025
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ shahargl
✅ DolevNe
❌ Yarin-Shitrit
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the test - wouldn't it pass regardless of the fix? if I understand correctly - the bug occur when > 1000 alerts?

@DolevNe DolevNe closed this Sep 1, 2025
@DolevNe DolevNe deleted the fix-old-alerts-not-showing branch September 1, 2025 06:49
@DolevNe DolevNe restored the fix-old-alerts-not-showing branch September 1, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API API related issues Bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Route get alerts/{fingerprint} doesn't work as expected, can't fetch an alert that isn't in the last 1000 alerts

5 participants