Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions keep/api/routes/alerts.py
Original file line number Diff line number Diff line change
Expand Up @@ -757,8 +757,8 @@ def get_alert(
"tenant_id": tenant_id,
},
)
all_alerts = get_all_alerts(authenticated_entity=authenticated_entity)
alert = list(filter(lambda alert: alert.fingerprint == fingerprint, all_alerts))
all_alerts = get_alerts_by_fingerprint(tenant_id=tenant_id,fingerprint=fingerprint)
alert = convert_db_alerts_to_dto_alerts(all_alerts)
if alert:
return alert[0]
else:
Expand Down
54 changes: 54 additions & 0 deletions tests/test_get_alert_by_fingerprint.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import pytest
from datetime import datetime, timedelta
import pytz

from keep.api.models.alert import AlertStatus
from tests.fixtures.client import client, setup_api_key, test_app # noqa


@pytest.mark.parametrize(
"test_app",
[
{
"AUTH_TYPE": "NOAUTH",
},
],
indirect=True,
)
def test_get_alert_by_fingerprint_success(db_session, client, test_app, create_alert):
setup_api_key(db_session, "some-api-key")

fingerprint = "unit-test-fp"
now = datetime.now(tz=pytz.utc)
create_alert(fingerprint, AlertStatus.FIRING, now - timedelta(minutes=1))

response = client.get(
f"/alerts/{fingerprint}", headers={"x-api-key": "some-api-key"}
)

assert response.status_code == 200
body = response.json()
assert body["fingerprint"] == fingerprint
assert body["status"].lower() == "firing"


@pytest.mark.parametrize(
"test_app",
[
{
"AUTH_TYPE": "NOAUTH",
},
],
indirect=True,
)
def test_get_alert_by_fingerprint_not_found(db_session, client, test_app):
setup_api_key(db_session, "some-api-key")

response = client.get(
"/alerts/non-existent-fp", headers={"x-api-key": "some-api-key"}
)

assert response.status_code == 404
assert response.json()["detail"] == "Alert not found"


Loading