Skip to content

Improve load_weights and the test coverage. #21454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

james77777778
Copy link
Contributor

@james77777778 james77777778 commented Jul 4, 2025

Fix #21404

This PR adds error msg in load_weights and increases test coverage.

Colab:
https://colab.research.google.com/drive/1f-Idlm_BMLmP-_gym0bSqCPz7bl7PAMu?usp=sharing

cc @DLumi

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (18ab462) to head (3601f4b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21454      +/-   ##
==========================================
+ Coverage   82.74%   82.75%   +0.01%     
==========================================
  Files         565      565              
  Lines       55300    55304       +4     
  Branches     8624     8626       +2     
==========================================
+ Hits        45756    45766      +10     
+ Misses       7439     7436       -3     
+ Partials     2105     2102       -3     
Flag Coverage Δ
keras 82.56% <100.00%> (+0.01%) ⬆️
keras-jax 63.35% <100.00%> (+0.01%) ⬆️
keras-numpy 58.55% <100.00%> (+0.01%) ⬆️
keras-openvino 33.78% <0.00%> (-0.01%) ⬇️
keras-tensorflow 63.78% <100.00%> (+0.01%) ⬆️
keras-torch 63.38% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james77777778 james77777778 force-pushed the fix-save-load-weights branch from 8a2833c to 3601f4b Compare July 4, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weight loading: skip_mismatch is not respected for H5 format
3 participants