-
Notifications
You must be signed in to change notification settings - Fork 23
Fix/pylint python39 compatibility #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/pylint python39 compatibility #141
Conversation
- Add conditional pylint installation in [project.optional-dependencies] - Python 3.10+: pylint >=4.0.0 - Python 3.9: pylint >=2.0, <4.0 - Remove hardcoded pylint from [tool.poetry.dev-dependencies] - Maintains backwards compatibility with Python 3.9 while allowing Python 3.10+ users to use pylint v4 Fixes Python 3.9 CI/CD compatibility issue with pylint v4 upgrade. This PR builds on top of PR kinde-oss#133 (pylint v4 upgrade) and adds Python 3.9 compatibility.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe README.md file was updated with a Development Setup section documenting the editable installation process with development dependencies, including specific tool requirements and conditional pylint version specifications based on Python version compatibility. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with the following thought:
- since users now must use
pip install -e ".[dev], should this be more visibly and clearly documented elsewhere other than.tomlfile comment?
Addresses reviewer feedback by documenting the requirement to use 'pip install -e ".[dev]"' for installing development dependencies. Also explains the conditional pylint installation based on Python version.
I added some details in the ReadMe document. |
Addresses co-worker feedback: pyproject.toml is used both for packaging and Poetry environment management. Since Poetry doesn't support multiple conditional version constraints for the same package, we add pylint with the Python 3.9-compatible version (>=2.0,<4.0) to ensure Poetry workflows don't break. Python 3.10+ users can still get pylint >=4.0.0 via: - pip install -e ".[dev]" (uses conditional markers from [project.optional-dependencies]) - Manual upgrade after poetry install This maintains backward compatibility with Python 3.9 while supporting both Poetry and pip-based workflows.
Explain your changes
This commit adds conditional pylint installation using PEP 508 environment
markers in the [project.optional-dependencies] section:
Changes:
This maintains full backwards compatibility with Python 3.9 while allowing
Python 3.10+ users to benefit from pylint v4 features.
Fixes Python 3.9 CI/CD compatibility issue with pylint v4 upgrade.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.