Skip to content

Fix/pylint python39 compatibility #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrandtKruger wants to merge 4 commits into
base: main
Choose a base branch
from
+36 −1
Open

Fix/pylint python39 compatibility #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21d24f5
chore(deps): update dependency pylint to v4
renovate[bot] Nov 20, 2025
1d495b9
fix: make pylint conditional to maintain Python 3.9 compatibility
BrandtKruger Nov 25, 2025
0a6405b
docs: add development setup section to README
BrandtKruger Dec 6, 2025
c9a08a3
fix: add pylint back to Poetry dev-dependencies for compatibility
BrandtKruger Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,20 @@ If you're upgrading from v1 of the Kinde Python SDK, we've prepared comprehensiv

Please refer to Kinde's [contributing guidelines](https://github.com/kinde-oss/.github/blob/489e2ca9c3307c2b2e098a885e22f2239116394a/CONTRIBUTING.md).

### Development Setup

To set up the development environment, install the package in editable mode with development dependencies:

```bash
pip install -e ".[dev]"
```

**Note:** The `dev` optional dependency group includes all development tools (pytest, mypy, pylint, etc.). Pylint is conditionally installed based on your Python version:
- **Python 3.10+**: pylint >=4.0.0
- **Python 3.9**: pylint >=2.0, <4.0

This ensures compatibility with Python 3.9 while allowing newer Python versions to use the latest pylint features.

## License

By contributing to Kinde, you agree that your contributions will be licensed under its MIT License.
23 changes: 22 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,21 @@ fastapi = [
flask = [
"flask >=3.0.0, <4.0.0",
]
dev = [
"pytest >=7.4.0",
"pytest-cov >=4.1.0",
"pytest-django >=4.5.2",
"mypy >=1.5.0",
"bandit >=1.7",
"pylint >=4.0.0; python_version >= '3.10'",
"pylint >=2.0, <4.0; python_version < '3.10'",
"pycodestyle >=2.0",
"pytest-asyncio >=0.26.0",
"pytest-timeout >=2.2.0",
"black >=24.3.0",
"flake8 >=6.1.0",
"isort >=5.12.0",
]

[project.urls]
"Homepage" = "https://github.com/kinde-oss/kinde-python-sdk"
Expand All @@ -71,7 +86,13 @@ pytest-cov = "^4.1.0"
pytest-django = "^4.5.2"
mypy = "^1.5.0"
bandit = "^1.7"
pylint = "^2.0"
# pylint is conditionally installed based on Python version to maintain Python 3.9 compatibility
# Python 3.10+: pylint >=4.0.0 (use pip install -e ".[dev]" for conditional installation)
# Python 3.9: pylint >=2.0, <4.0
# Note: Poetry doesn't support multiple conditional version constraints for the same package.
# This entry uses the Python 3.9-compatible version. Python 3.10+ users can upgrade manually
# or use: pip install -e ".[dev]" which respects the conditional markers in [project.optional-dependencies]
pylint = ">=2.0,<4.0"
pycodestyle = "^2.0"
pytest-asyncio = "^0.26.0"
pytest-timeout = "^2.2.0"
Expand Down