fix(accountSettings): error handling in email section DEV-1119 (old PR) #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
force-pushed
the
beta
branch
2 times, most recently
from
d0b0d13 to
fd5246d
Compare
magicznyleszek
changed the title
|
I've created a linear issue to make it more manageable to tackle it https://linear.app/kobotoolbox/issue/DEV-1119/fixaccountsettings-error-handling-in-email-section |
magicznyleszek
changed the title
magicznyleszek
changed the title
9 tasks
magicznyleszek
added a commit
that referenced
this pull request
Oct 15, 2025
### 📣 Summary Displays error in UI when changing email and API validates the proposed email as invalid. ### 💭 Notes Supersedes #4224. ### 👀 Preview steps To test error handling from BE, go to `emailSection.component.tsx` and modify `handleSubmit` function (comment out all the lines but `setNewUserEmail(email.newEmail)`). 1. ℹ️ have an account 2. go to Account Settings → Security 3. type wrong email and use "Change" button 4. 🔴 [on main] no error being displayed 5. 🟢 [on PR] error being displayed next to the button
|
Closing in favor of #6350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning for implementing this way:
fetchDatacode inapi.tsand because of the howfetchthrow errors so I do the check in the response handlerDescription
When a bad email is sent the user isn't notified, this adds a basic error to let the user know.