Skip to content

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Oct 9, 2025

🗒️ Checklist

  1. run linter locally
  2. update developer docs (API, README, inline, etc.), if any
  3. for user-facing doc changes create a Zulip thread at #Support Docs Updates, if any
  4. draft PR with a title <type>(<scope>)<!>: <title> DEV-1234
  5. assign yourself, tag PR: at least Front end and/or Back end or workflow
  6. fill in the template below and delete template comments
  7. review thyself: read the diff and repro the preview as written
  8. open PR & confirm that CI passes & request reviewers, if needed
  9. delete this section before merging

📣 Summary

Displays error in UI when changing email and API validates the proposed email as invalid.

💭 Notes

Supersedes #4224.

👀 Preview steps

To test error handling from BE, go to emailSection.component.tsx and modify handleSubmit function (comment out all the lines but setNewUserEmail(email.newEmail)).

  1. ℹ️ have an account
  2. go to Account Settings → Security
  3. type wrong email and use "Change" button
  4. 🔴 [on main] no error being displayed
  5. 🟢 [on PR] error being displayed next to the button

@magicznyleszek magicznyleszek self-assigned this Oct 9, 2025
@magicznyleszek magicznyleszek requested a review from duvld October 9, 2025 14:06
@magicznyleszek magicznyleszek marked this pull request as ready for review October 9, 2025 14:08
@magicznyleszek magicznyleszek removed the request for review from jamesrkiger October 9, 2025 14:08
@magicznyleszek magicznyleszek marked this pull request as draft October 9, 2025 14:16
@magicznyleszek magicznyleszek marked this pull request as ready for review October 9, 2025 15:41
@magicznyleszek magicznyleszek merged commit 8f05aaf into main Oct 15, 2025
11 checks passed
@magicznyleszek magicznyleszek deleted the leszek/dev-1119-error-handling-email branch October 15, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants