Skip to content

Conversation

@osipxd
Copy link
Member

@osipxd osipxd commented Sep 19, 2025

Subsystem
Core

Motivation
KTOR-8901 Remove AnnotationTarget.FUNCTION from @KtorDsl

Solution
This PR removes wrongly used @KtorDsl annotation to make it possible to remove the annotation target FUNCTION in the future.

@osipxd osipxd requested a review from bjhham September 19, 2025 11:18
@osipxd osipxd self-assigned this Sep 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch osipxd/ktordsl-remove-function-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this into the next patch release, however this change might break code misusing the @KtorDsl annotation. The main point why I want it to be included is that this change prevents further misuse of the @KtorDsl annotation.

It sounds like you meant to select main for the base branch in this case...

@osipxd
Copy link
Member Author

osipxd commented Sep 19, 2025

We could merge all changes except for removing the target into the patch release 🤔
And merge removing the target into the main.

@osipxd osipxd force-pushed the osipxd/ktordsl-remove-function-target branch from 7f73c21 to da85cfb Compare September 19, 2025 11:30
@osipxd osipxd force-pushed the osipxd/ktordsl-remove-function-target branch from da85cfb to c6fa538 Compare October 21, 2025 10:45
@osipxd osipxd changed the title KTOR-8901 Remove AnnotationTarget.FUNCTION from @KtorDsl KTOR-8901 Remove @KtorDsl from functions Oct 21, 2025
@osipxd osipxd force-pushed the osipxd/ktordsl-remove-function-target branch from c6fa538 to a797a46 Compare October 21, 2025 13:23
@osipxd osipxd enabled auto-merge (squash) November 3, 2025 16:37
@osipxd osipxd force-pushed the osipxd/ktordsl-remove-function-target branch from a797a46 to 5f8751c Compare November 3, 2025 16:38
@osipxd osipxd merged commit 2867154 into release/3.x Nov 3, 2025
14 of 17 checks passed
@osipxd osipxd deleted the osipxd/ktordsl-remove-function-target branch November 3, 2025 17:27
osipxd added a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants