-
Notifications
You must be signed in to change notification settings - Fork 140
chore: 🔨 Use the v0.3.0 llm-d-inference-sim image tag. #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🔨 Use the v0.3.0 llm-d-inference-sim image tag. #1140
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @yafengio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hi @yafengio, ideally we would like to use latest images when things are stable enough to do it. until that happens, I think it would be better for us to bump sim version in a controlled manner.. can you update the sim version to v0.2 explicitly and make sure e2e-tests are passing? |
@nirrozenbaum Thank you for your reply. I will try to solve it. |
/ok-to-test adding this to allow ci to run e2e tests for this PR |
@yafengio hi, is there any update on this issue? |
Currently unable to upgrade to the latest version, but I noticed the sim repository has fixed some issues. I'll conduct a new round of testing as soon as possible. |
0e338bc
to
2823434
Compare
@nirrozenbaum hi, I adapted based on the latest llm-d-inference-sim image (v0.3.0), and all e2e tests passed. Please have a review. Thx Ran 2 of 2 Specs in 70.359 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (70.36s)
PASS
ok sigs.k8s.io/gateway-api-inference-extension/test/e2e/epp 70.376s |
@yafengio Looks great! Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, yafengio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…gs#1140) * chore: 🔨 Use the latest llm-d-inference-sim image tag. * feat: 🔨 Compatible with llm-d-inference-sim v0.3.0. * chore: ⬆️ bump llm-d-inference-sim to v0.3.0 (default). * chore: ⬆️ replace with v0.3.0 tag.
As the title suggests, we use the v0.3.0(latest) sim image to take advantage of the latest features.
For example, the size of the mirror image, etc. (121MB -> 37.2MB)