-
Notifications
You must be signed in to change notification settings - Fork 145
chore: added proper inference-extension-
prefix for demostration manifests
#1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: added proper inference-extension-
prefix for demostration manifests
#1194
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nekomeowww The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @nekomeowww. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c73c428
to
e8d88b9
Compare
e8d88b9
to
08d56f9
Compare
can we change these to |
Sure NP. Updated. |
there are more places that should be updated if we would like to do this change. this change is definitely not local to this file. |
I was testing to integrate GAIE to https://github.com/knoway-dev/knoway, and these tutorial used files are the most often used files during the workflow so I updated them in much more higher priority. Sure. Let me check for them. |
/ok-to-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -177,7 +178,8 @@ data: | |||
kind: ClusterRole | |||
apiVersion: rbac.authorization.k8s.io/v1 | |||
metadata: | |||
name: pod-read | |||
name: inference-gateway-read-clusterrole | |||
namespace: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer we remove the namespace
definitions in this file so a user can set a different namespace manually using kubectl apply
.
I prefer holding off on merging this PR until v1.0 is cut. I want to avoid having any last-minute regressions. |
/hold |
Summary
Followed the naming pattern that Istio uses:
where
<group/type/category>-<role>-<resoucename>
.Test