Skip to content

chore: added proper inference-extension- prefix for demostration manifests #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nekomeowww
Copy link
Contributor

@nekomeowww nekomeowww commented Jul 21, 2025

Summary

Followed the naming pattern that Istio uses:

istio-reader-clusterrole-istio-system
istiod-clusterrole-istio-system

where <group/type/category>-<role>-<resoucename>.

Test

$ kubectl apply -f '/Users/neko/Git/kubernetes-sigs/gateway-api-inference-extension/config/manifests/inferencepool-resources.yaml'
inferencepool.inference.networking.x-k8s.io/vllm-llama3-8b-instruct created
service/vllm-llama3-8b-instruct-epp created
deployment.apps/vllm-llama3-8b-instruct-epp created
configmap/inference-extension-plugins-config created
clusterrole.rbac.authorization.k8s.io/inference-extension-read-clusterrole created
clusterrolebinding.rbac.authorization.k8s.io/inference-extension-read-clusterrole-binding created

Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 2ddad9c
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6881c3585c6e820008961348
😎 Deploy Preview https://deploy-preview-1194--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nekomeowww
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @nekomeowww. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2025
@nekomeowww nekomeowww force-pushed the dev/manifests-name-update branch from c73c428 to e8d88b9 Compare July 21, 2025 10:12
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2025
@nekomeowww nekomeowww force-pushed the dev/manifests-name-update branch from e8d88b9 to 08d56f9 Compare July 21, 2025 10:15
@kfswain
Copy link
Collaborator

kfswain commented Jul 23, 2025

can we change these to inference-gateway if we want to add this prefix? That's the more common name we use, and the one we would like to present for the most part (the name of the repo is a regret of mine)

@nekomeowww
Copy link
Contributor Author

can we change these to inference-gateway if we want to add this prefix? That's the more common name we use, and the one we would like to present for the most part (the name of the repo is a regret of mine)

Sure NP. Updated.

@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Jul 29, 2025

there are more places that should be updated if we would like to do this change.
there's also the manifests in conformance tests and in e2e tests.
also the helm charts + templates of the charts.
I would also check all the quickstart guides which I'm pretty sure have references to these resources.

this change is definitely not local to this file.

@nekomeowww
Copy link
Contributor Author

I was testing to integrate GAIE to https://github.com/knoway-dev/knoway, and these tutorial used files are the most often used files during the workflow so I updated them in much more higher priority.

Sure. Let me check for them.

@kfswain
Copy link
Collaborator

kfswain commented Jul 31, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -177,7 +178,8 @@ data:
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: pod-read
name: inference-gateway-read-clusterrole
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we remove the namespace definitions in this file so a user can set a different namespace manually using kubectl apply.

@danehans
Copy link
Contributor

I prefer holding off on merging this PR until v1.0 is cut. I want to avoid having any last-minute regressions.

@nirrozenbaum
Copy link
Contributor

I prefer holding off on merging this PR until v1.0 is cut. I want to avoid having any last-minute regressions.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants