replace spinner lib to upstream

[medyagh]

historically because of these reasons
briandowns/spinner#121
briandowns/spinner#157

@alonyb
we used our a contributors fork since his PR couldnt be merged briandowns/spinner#108
but I dont think we need to use the ancient fork anymore, it seems like the newer versions just magically work fine at least on my macos

this PR gets rid of this go.mod replace and uses upstream

$ mk start
😄  minikube v1.36.0 on Darwin 15.5 (arm64)
💡  Unable to run vmnet-helper without a password
    To configure vment-helper to run without a password, please check the documentation:
    https://github.com/nirs/vmnet-helper/#granting-permission-to-run-vmnet-helper
Password: 
✨  Automatically selected the vfkit driver. Other choices: ssh, krunkit (experimental)
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🔥  Creating vfkit VM (CPUs=2, Memory=6144MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.33.2 on Docker 28.3.2 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/ok-to-start

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21115 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 52.7s    │ 52.4s                  │
│ enable ingress │ 14.9s    │ 15.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 51.0s 52.2s 53.1s 54.4s 52.9s
Times for minikube (PR 21115) start: 54.8s 53.5s 50.4s 50.1s 53.4s

Times for minikube (PR 21115) ingress: 15.0s 15.0s 16.0s 15.0s 15.1s
Times for minikube ingress: 15.0s 15.0s 15.0s 14.5s 15.0s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21115 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 26.0s    │ 24.5s                  │
│ enable ingress │ 24.4s    │ 12.3s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 25.1s 27.6s 26.8s 28.1s 22.5s
Times for minikube (PR 21115) start: 26.6s 26.3s 23.6s 23.8s 22.4s

Times for minikube ingress: 12.8s 12.3s 12.8s 72.8s 11.3s
Times for minikube (PR 21115) ingress: 12.3s 12.3s 12.3s 12.3s 12.3s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21115 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.2s    │ 24.0s                  │
│ enable ingress │ 26.4s    │ 22.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.8s 23.6s 21.0s 21.9s 21.6s
Times for minikube (PR 21115) start: 21.0s 25.2s 25.3s 24.4s 24.4s

Times for minikube ingress: 22.8s 39.3s 23.3s 23.7s 22.8s
Times for minikube (PR 21115) ingress: 23.3s 22.3s 22.8s 22.8s 22.8s