Skip to content

[KEP-3960] - update docs for GA #51401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

[KEP-3960] - update docs for GA #51401

merged 1 commit into from
Aug 6, 2025

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Jun 27, 2025

Description

Document PodLifecycleSleepAction for GA

Issue

GA doc requirement for KEP-3960

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mikedanese June 27, 2025 05:36
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from reylejano June 27, 2025 05:36
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 6a1b6c1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/687f41ed0a5b900008e8e2f9

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2025
@AxeZhan AxeZhan mentioned this pull request Jun 27, 2025
Closed
14 tasks
@lmktfy
Copy link
Contributor

lmktfy commented Jun 27, 2025

Marking as a work in progress
/retitle [WIP][KEP-3960] - update docs for GA

@k8s-ci-robot k8s-ci-robot changed the title [PLACEHOLDER][KEP-3960] - update docs for GA [WIP][KEP-3960] - update docs for GA Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2025
@AxeZhan AxeZhan changed the title [WIP][KEP-3960] - update docs for GA [KEP-3960] - update docs for GA Jul 21, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025
@AxeZhan
Copy link
Member Author

AxeZhan commented Jul 21, 2025

/retest

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2025
tengqm
tengqm reviewed Jul 22, 2025
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates/PodLifecycleSleepAction.md
- stage: stable
defaultValue: true
fromVersion: "1.34"
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update content/en/docs/concepts/containers/container-lifecycle-hooks.md as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already updated? Or are you suggesting something else I didn't include in this pr?
BTW, is this related to the failed tests? I'm confused why the tests are failing and I can't re-run them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already updated?

No. I don't think so.

Or are you suggesting something else I didn't include in this pr?

The page I mentioned still says that the gate is in Beta, IIRC.

BTW, is this related to the failed tests? I'm confused why the tests are failing and I can't re-run them.

No. You have to rebase your PR to the HEAD of dev-1.34 branch where a temporary bug has been fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page I mentioned still says that the gate is in Beta, IIRC.

Ah I think there might be a misunderstanding.

There is another gate called PodLifecycleSleepActionAllowZero in the page you mentioned, that's a different gate than PodLifecycleSleepAction.

Can you confirm? I should have deleted the part describing PodLifecycleSleepAction is in beta status.
https://github.com/kubernetes/website/pull/51401/files#diff-db7d68386819ee82bcfefbc968191fec950a8dca9d7c9edd413d646ddc034371L67

However, since PodLifecycleSleepActionAllowZero and PodLifecycleSleepAction are closely related, and both will be GA in 1.34, maybe we can also update the docs for them in one same pr @sreeram-venkitesh

No. You have to rebase your PR to the HEAD of dev-1.34 branch where a temporary bug has been fixed.

Thanks, I'll have a try.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had opened #51490 for PodLifecycleSleepActionAllowZero for meeting the docs deadlines. The only docs change there is to update the feature gate and remove a note. I'm okay to merge the changes in the same PR. I can do the same as I did for the code PR, push my commit to this branch as co-author. Please let me know whatever works!

@netlify Netlify
Copy link

netlify bot commented Jul 22, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a1b6c1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/687f41ede58382000829a5a7
😎 Deploy Preview https://deploy-preview-51401--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@windsonsea
Copy link
Member

/remove-language zh
/remove-area localization

@k8s-ci-robot k8s-ci-robot removed language/zh Issues or PRs related to Chinese language area/localization General issues or PRs related to localization labels Jul 22, 2025
@yujen77300
Copy link
Contributor

Hello @AxeZhan 👋! I'm reaching out from the Docs team.

Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@sreeram-venkitesh
Copy link
Member

@AxeZhan Can we merge the docs changes for PodLifecycleSleepActionAllowZero separately in #51490? I'll be at KubeCon India on 6th and 7th and since we have the PR ready I think it'll be easier to merge them separate than adding the changes here. Please let me know your thoughts, thanks!

@AxeZhan
Copy link
Member Author

AxeZhan commented Aug 5, 2025

@AxeZhan Can we merge the docs changes for PodLifecycleSleepActionAllowZero separately in #51490? I'll be at KubeCon India on 6th and 7th and since we have the PR ready I think it'll be easier to merge them separate than adding the changes here. Please let me know your thoughts, thanks!

I think both way is ok. Since both pr is already created. Let's go separatly.

@AxeZhan
Copy link
Member Author

AxeZhan commented Aug 5, 2025

/ping @thockin @aojea

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@drewhagen
Copy link
Member

Hello @AxeZhan 👋!

I'm reaching out on behalf of the Release Docs team.

A friendly reminder that Docs Freeze is approaching today, at 18:00 PT (in less than 8 hours). This documentation PR appears to still be under review. Here's where it currently stands:

  • Needs a technical approval from SIG Node - @thockin @aojea have been pinged
  • Comments and concerns from SIG Docs (at this moment) seem to be addressed
  • Needs a lgtm label applied
  • Needs an approval label applied

If you wish to include this enhancement in 1.34 but are concerned about meeting the deadline, please consider proactively filing an exception request. Thanks!

cc: @kubernetes/sig-node-leads FYSA

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1672109247dec9c2a257e6873810f0298e42be9

@k8s-ci-robot k8s-ci-robot merged commit 225f8e4 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@aojea
Copy link
Member

aojea commented Aug 7, 2025

/lgtm

This is a graduation of a feature gate to GA, the only requirement missing were the e2e test so I assume the content is ok kubernetes/kubernetes#132595

The same PR also graduated PodLifecycleSleepActionAllowZero to GA that has a PR in place #51490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@reylejano reylejano Awaiting requested review from reylejano

+1 more reviewer

@sreeram-venkitesh sreeram-venkitesh sreeram-venkitesh left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.