Skip to content

[KEP-3960] - update docs for GA #51401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

[KEP-3960] - update docs for GA #51401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions content/en/docs/concepts/containers/container-lifecycle-hooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ There are three types of hook handlers that can be implemented for Containers:
Resources consumed by the command are counted against the Container.
* HTTP - Executes an HTTP request against a specific endpoint on the Container.
* Sleep - Pauses the container for a specified duration.
This is a beta-level feature default enabled by the `PodLifecycleSleepAction`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/).

{{< note >}}
The beta level `PodLifecycleSleepActionAllowZero` feature gate which is enabled by default from v1.33.
Expand Down
4 changes: 4 additions & 0 deletions ...reference/command-line-tools-reference/feature-gates/PodLifecycleSleepAction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,9 @@ stages:
- stage: beta
defaultValue: true
fromVersion: "1.30"
toVersion: "1.33"
- stage: stable
defaultValue: true
fromVersion: "1.34"
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update content/en/docs/concepts/containers/container-lifecycle-hooks.md as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already updated? Or are you suggesting something else I didn't include in this pr?
BTW, is this related to the failed tests? I'm confused why the tests are failing and I can't re-run them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already updated?

No. I don't think so.

Or are you suggesting something else I didn't include in this pr?

The page I mentioned still says that the gate is in Beta, IIRC.

BTW, is this related to the failed tests? I'm confused why the tests are failing and I can't re-run them.

No. You have to rebase your PR to the HEAD of dev-1.34 branch where a temporary bug has been fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page I mentioned still says that the gate is in Beta, IIRC.

Ah I think there might be a misunderstanding.

There is another gate called PodLifecycleSleepActionAllowZero in the page you mentioned, that's a different gate than PodLifecycleSleepAction.

Can you confirm? I should have deleted the part describing PodLifecycleSleepAction is in beta status.
https://github.com/kubernetes/website/pull/51401/files#diff-db7d68386819ee82bcfefbc968191fec950a8dca9d7c9edd413d646ddc034371L67

However, since PodLifecycleSleepActionAllowZero and PodLifecycleSleepAction are closely related, and both will be GA in 1.34, maybe we can also update the docs for them in one same pr @sreeram-venkitesh

No. You have to rebase your PR to the HEAD of dev-1.34 branch where a temporary bug has been fixed.

Thanks, I'll have a try.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had opened #51490 for PodLifecycleSleepActionAllowZero for meeting the docs deadlines. The only docs change there is to update the feature gate and remove a note. I'm okay to merge the changes in the same PR. I can do the same as I did for the code PR, push my commit to this branch as co-author. Please let me know whatever works!

Enables the `sleep` action in Container lifecycle hooks.