Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,6 @@ Resources consumed by the command are counted against the Container.
This is a beta-level feature default enabled by the `PodLifecycleSleepAction`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/).

{{< note >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a docs perspective, the only thing to note is that this feature is mentioned only in this note block (aside from the feature gate description). With the note block being removed, there's currently no documentation page that references it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible way forward would be to merge the content of the note in the Sleep bullet point above. Something like (draft written on the fly)

Since Kubernetes vX.Y it is possible to set a sleep duration of zero seconds (effectively a no-op) for your Sleep lifecycle hooks. You can disable this option by setting the beta level `PodLifecycleSleepActionAllowZero` feature gate to false.

The beta level `PodLifecycleSleepActionAllowZero` feature gate which is enabled by default from v1.33.
It allows you to set a sleep duration of zero seconds (effectively a no-op) for your Sleep lifecycle hooks.
{{< /note >}}

### Hook handler execution

When a Container lifecycle management hook is called,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,9 @@ stages:
- stage: beta
defaultValue: true
fromVersion: "1.33"
toVersion: "1.33"
- stage: stable
defaultValue: true
fromVersion: "1.34"
---
Enables setting zero value for the `sleep` action in [container lifecycle hooks](/docs/concepts/containers/container-lifecycle-hooks/).