PodLifecycleSleepActionAllowZero to GA #51490
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/sig node |
k8s-ci-robot
added
size/XS
github-project-automation
bot
moved this to Triage
in SIG Node: code and documentation PRs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
@sreeram-venkitesh Perhaps we should consider setting the dev-1.34 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting stable in v1.34
|
Ah yes, I made this mistake last time as well. I'll clean this up this week. |
|
@dipesh-rawat I've fixed the base branch. Sorry for the delay on this. I believe this PR is ready for review. I don't see any other changes. The info on feature gates in the references for different components would be auto updated right? I don't remember doing anything for this last cycle when the gate graduated to beta. Thanks in advance! CC: @michellengnx @rashansmith (Docs lead and assigned shadow) |
|
@sreeram-venkitesh If this is ready for review, it might be a good time to remove the |
sreeram-venkitesh
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Thanks Dipesh! Fixed now. I donno how I missed that 😂 |
|
Hello @sreeram-venkitesh 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you! |
|
@dipesh-rawat Can you please take a look at this PR. It should be a simple change from SIG Docs perspective. I will ping SIG Node folsk today for SIG review. |
| This is a beta-level feature default enabled by the `PodLifecycleSleepAction` | ||
| [feature gate](/docs/reference/command-line-tools-reference/feature-gates/). | ||
|
|
||
| {{< note >}} |
There was a problem hiding this comment.
From a docs perspective, the only thing to note is that this feature is mentioned only in this note block (aside from the feature gate description). With the note block being removed, there's currently no documentation page that references it.
There was a problem hiding this comment.
A possible way forward would be to merge the content of the note in the Sleep bullet point above. Something like (draft written on the fly)
Since Kubernetes vX.Y it is possible to set a sleep duration of zero seconds (effectively a no-op) for your Sleep lifecycle hooks. You can disable this option by setting the beta level `PodLifecycleSleepActionAllowZero` feature gate to false.
|
/milestone 1.34 |
k8s-ci-robot
added
the
approved
|
Hello @sreeram-venkitesh 👋! I'm reaching out on behalf of the Release Docs team. It looks like this PR has an approval from SIG Docs. Has SIG Node reviewed yet? A friendly reminder that Docs Freeze is approaching today, at 18:00 PT (less than 9 hours). This documentation appears to still be under review. To meet the Docs Freeze, this PR must complete a technical review with SIG Node as well as If you wish to include this enhancement in 1.34 but are concerned about meeting the deadline, please consider proactively filing an exception request. Thanks! cc: @kubernetes/sig-node-leads FYSA |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e47c1b22db0c51ab05ba2fafdb0ac537d1c57421
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Triage
to Done
in SIG Node: code and documentation PRs
Description
Issue
Docs PR for kubernetes/enhancements#4818 GA graduation in v1.34.