-
Notifications
You must be signed in to change notification settings - Fork 301
Support putting external images into the local registry of the kubevirtci cluster (#3801) #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @gaohoward. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@awels Hi Alex, just updated the branch. Pls take a look and see if it looks better. Thanks! |
…rtci cluster (kubevirt#3801) User can define an environment variable EXTRA_IMAGES that contains a list of external image urls separated by spaces. At the end of 'make cluster-up' target the EXTRA_IMAGES are processed by a script ./cluster-up/extra-images.sh so that for each image url, it pulls the image and then push the image into the local registry. Then when 'make cluster-sync' is invoked, it searches all external image urls in the generated yamls in _out/manifests/ and replaces them with corresponding urls in the local registry (registry:5000) Signed-off-by: Howard Gao <[email protected]>
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
User can define an environment variable EXTRA_IMAGES that contains a list of external image urls separated by spaces.
At the end of 'make cluster-up' target the EXTRA_IMAGES are processed by a script ./cluster-up/extra-images.sh so that for each image url, it pulls the image and then push the image into the local registry.
Then when 'make cluster-sync' is invoked, it searches all external image urls in the generated yamls in _out/manifests/ and replaces them with corresponding urls in the local registry (registry:5000)
What this PR does / why we need it:
Added functionality for cluster-up target to allow adding external images to the internal local docker registry
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3801
Special notes for your reviewer:
Release note: