Move PR write permissions #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beklapko
commented
Aug 15, 2025
|
|
||
| jobs: | ||
| create-preview: | ||
| permissions: | ||
| pull-requests: write # Required to comment on PRs |
There was a problem hiding this comment.
@eyurtsev I moved this to the job level because I didn't think there was a way to set permissions on an individual step. Is this what you were thinking or was there a different solution?
There was a problem hiding this comment.
Not sure this change is the cause yet since it didn't fail on the step for commenting on the PR but the preview workflow failed: https://github.com/langchain-ai/docs/actions/runs/16992739025/job/48175935263?pr=169#step:11:892
|
Preview ID generated: preview-brodye-1755274036-4246463 |
lnhsingh
approved these changes
Aug 15, 2025
|
Preview ID generated: preview-brodye-1755274800-4c212f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating changes from Eugene: https://github.com/langchain-ai/docs/pull/162/files#r2278029839