genai: improve _convert_pydantic_to_genai_function()
#1065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrxy
requested changes
Sep 15, 2025
| }, | ||
| ) | ||
| return function_declaration | ||
| def _convert_pydantic_to_genai_function(model: BaseModel, function_name: str = None) -> dict: |
There was a problem hiding this comment.
Could you add test and inline citation to the Gemini function tool schema? Also run lint please 🥺
There was a problem hiding this comment.
sorry, it will take time for me so i will try to make updates within 2 weeks.
mdrxy
changed the title
_convert_pydantic_to_genai_function()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Refactored the
_convert_pydantic_to_genai_functionfunction to improve compatibility with Gemini'sfunction_declarationsformat. The internal logic was updated to ensure that apydantic.BaseModelis properly converted to Gemini-compatible tool definitions. No changes were made to the function name, signature, or external interface.Relevant issues
N/A
Type
🐛 Bug Fix
🧹 Refactoring
Changes
Rewrote the internal logic of
_convert_pydantic_to_genai_functionto:function_declarationslistdescription