Check for empty patch filenames. #156
Conversation
quic-bjorande
left a comment
quic-bjorande
left a comment
There was a problem hiding this comment.
Took me a while to figure out that we indeed have an issue here.
If the "filename" attribute is either empty or absent, attr_as_string() returns NULL, which will trip us on the strcmp() below. By including such details to your explanation, this would have been obvious - and I would have been more eager to merge the previous PR you had.
That said, what does it mean when a patch tag has an empty filename? Today we're crashing on them, with this change we're going to ignore them. But does the "filename" actually impact the patch?
Is it correct to ignore patch tags without filename, or is the "filename" attribute optional?
ykaire-qti
force-pushed
the
empty-filename
branch
from
283d013 to
6f63cea
Compare
andersson
left a comment
andersson
left a comment
There was a problem hiding this comment.
s/inlcude/include/ in commit message.
Per my previous comment, I think it would be nice to change "handle that scenario" to explicitly state that we're ignoring those entries. (And I still would like to know if that is the expected way to handle this long term)
ykaire-qti
force-pushed
the
empty-filename
branch
from
6f63cea to
b195cdf
Compare
ykaire-qti
force-pushed
the
empty-filename
branch
from
b195cdf to
6eaae75
Compare
andersson
left a comment
andersson
left a comment
There was a problem hiding this comment.
Please run "make check" and make sure it passes cleanly.
Please also add a statement in the commit message, saying that this behavior aligns with how other Qualcomm tools handles this.
ykaire-qti
force-pushed
the
empty-filename
branch
from
6eaae75 to
7986d35
Compare
Some device builds include patches with empty filenames. This change adds a check to ignore those patches and prevent segmentation faults. This approach ensures consistency with other Qualcomm tools, which also ignore such patches. Signed-off-by: Yvonne Kaire <[email protected]>
ykaire-qti
force-pushed
the
empty-filename
branch
from
7986d35 to
a3436e2
Compare
4 participants
Some device builds inlcude empty filenames. This change adds a check to handle that scenario and avoid segmentation faults.