fix: ensure NOTION_TOKEN takes priority for authentication #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation shows NOTION_TOKEN as the recommended approach, but code was checking OPENAPI_MCP_HEADERS first It results in unnecessary performance overhead for most users
travbuddy
approved these changes
Aug 13, 2025
tech-sumit
approved these changes
Aug 22, 2025
|
Whoever can please merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation prioritizes
OPENAPI_MCP_HEADERSoverNOTION_TOKEN, even though the documentation listsNOTION_TOKENas “Option 1 (recommended)”.This PR is...
NOTION_TOKENis availableOPENAPI_MCP_HEADERS