Skip to content

fix: ensure NOTION_TOKEN takes priority for authentication #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure NOTION_TOKEN takes priority for authentication #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/openapi-mcp-server/mcp/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,18 @@ export class MCPProxy {
}

private parseHeadersFromEnv(): Record<string, string> {
// First try OPENAPI_MCP_HEADERS (existing behavior)

// First try NOTION_TOKEN (recommended approach)
const notionToken = process.env.NOTION_TOKEN
if (notionToken) {
console.log('Using NOTION_TOKEN (recommended)');
return {
'Authorization': `Bearer ${notionToken}`,
'Notion-Version': '2022-06-28'
}
}

// Fallback to OPENAPI_MCP_HEADERS (for advanced use cases)
const headersJson = process.env.OPENAPI_MCP_HEADERS
if (headersJson) {
try {
Expand All @@ -142,15 +153,6 @@ export class MCPProxy {
}
}

// Alternative: try NOTION_TOKEN
const notionToken = process.env.NOTION_TOKEN
if (notionToken) {
return {
'Authorization': `Bearer ${notionToken}`,
'Notion-Version': '2022-06-28'
}
}

return {}
}

Expand Down