feat: use full minecraft version to get pack_format #472 #312
Conversation
edayot
changed the title
tests/snapshots/examples__build_basic_relative_location__0.pack.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
is this a build script? might be a poetry way to do it. or perhaps we move to uv and try that lol.
There was a problem hiding this comment.
Yes it's a build script, i wasn't sure were to put it (maybe in a scripts folder at the repo root).
For the poetry thing it's equivalent of adding a command (like the mecha command in the terminal), and i don't like adding a whole command for just small scripts
misode
left a comment
misode
left a comment
There was a problem hiding this comment.
Is it really a good idea to include this many large files in the package? I'm not sure how much that really matters realistically.
mecha/resources/patches.json
Outdated
| "1.18", "1.18.1", "1.18.2", | ||
| "1.19", "1.19.1", "1.19.2", "1.19.3", "1.19.4", | ||
| "1.20", "1.20.1", "1.20.2", "1.20.3", "1.20.4", "1.20.5", "1.20.6", | ||
| "1.21", "1.21.1", "1.21.2", "1.21.3", "1.21.4", "1.21.5" |
There was a problem hiding this comment.
We should probably make this a bit more maintainable...
There was a problem hiding this comment.
I think the system is meant to support multiple patches for different version :
Line 61 in b979a9b
|
Including all file only increase package size, since command tree are parsed when needed : Line 46 in b979a9b |
This comment was marked as spam.
This comment was marked as spam.
edayot
force-pushed
the
minecraft_version
branch
from
613f401 to
49f5873
Compare
4 participants
Paired with beet PR