-
Notifications
You must be signed in to change notification settings - Fork 105
Bump SDK to v2.0 #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump SDK to v2.0 #761
Conversation
* Remove custom JSON exceptions * Lint * Update src/Http/Serialize/Json.php Co-authored-by: Tomas Norkūnas <[email protected]> --------- Co-authored-by: Tomas Norkūnas <[email protected]>
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change removes custom JSON exception classes and replaces their usage throughout the codebase with PHP's built-in Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Serializer (Json)
participant PHP Engine
Client->>Serializer (Json): serialize(data)
Serializer (Json)->>PHP Engine: json_encode(data, JSON_THROW_ON_ERROR)
alt On error
PHP Engine-->>Client: throws \JsonException
else Success
PHP Engine-->>Serializer (Json): JSON string
Serializer (Json)-->>Client: JSON string
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I don't understand this. Shouldn't there be a v1 branch and the main would be v2? Now I see v2 branch, and main as v1 |
That's what we'll do. I just created the v1.x branch that we'll use for the v1 maintenance. Let's fix the conflicts here so we can merge this branch in I will take care of updating the CI settings to ensure we can work as follow in the future:
|
This is a draft PR to see CI results.
Related issue
See #749 for discussion regarding v2.0
Summary by CodeRabbit
Refactor
\JsonException
throughout the application.Tests
\JsonException
and updated related error message assertions.