Skip to content

Conversation

@NicolasHug
Copy link
Contributor

@NicolasHug NicolasHug commented Dec 2, 2025

Yes you read that right: CPU tests for GPU wheels. We can build the ARM GPU wheels but we can't test them (on GPU).

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2025
@NicolasHug NicolasHug marked this pull request as ready for review December 2, 2025 14:32
@NicolasHug NicolasHug marked this pull request as draft December 2, 2025 14:34
@NicolasHug NicolasHug changed the title Add aarch64 wheels Add CPU tests for aarch64 GPU wheels Dec 3, 2025

on:
push:
# push:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove those before merging. That's just to avoid triggering these other jobs as I was testing the new ones.

@NicolasHug NicolasHug marked this pull request as ready for review December 9, 2025 18:53
container:
image: pytorch/manylinuxaarch64-builder:cuda12.6
env:
cuda_version_without_periods: "126"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cuda version is specified outside of the matrix, as done in linux_cuda_wheel. Is that intentional?

matrix:
# 3.10 corresponds to the minimum python version for which we build
# the wheel unless the label cliflow/binaries/all is present in the
# PR.
# For the actual release we should add that label and change this to
# include more python versions.
python-version: ['3.10']
# We test against 12.6 and 13.0 to avoid having too big of a CI matrix,
# but for releases we should add 12.8.
cuda-version: ['12.6', '13.0']

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - yes that's intentional. In this new job we only test on a CUDA 12.6 machine, not a any other CUDA versions (see image: pytorch/manylinuxaarch64-builder:cuda12.6) above.

We don't need to test more CUDA versions because we can't run CUDA tests on ARM anyway (that's a test-infra limitation, from what I understand). And we still have to use a CUDA docker image because the wheels were built with CUDA support.

@NicolasHug NicolasHug merged commit 2c2a138 into meta-pytorch:main Dec 10, 2025
72 of 73 checks passed
@NicolasHug NicolasHug deleted the add_aarch64_wheels branch December 10, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants