-
Notifications
You must be signed in to change notification settings - Fork 77
Add CPU tests for aarch64 GPU wheels #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e034b15
Add aarch64 ffmpeg targets
NicolasHug f07d5ff
Add aarch64 wheel build CI job
NicolasHug 89a5444
Temporarily disable other jobs
NicolasHug dde4f36
Merge branch 'main' of github.com:pytorch/torchcodec into add_aarch64…
NicolasHug c9b3df6
Add test job?
NicolasHug ae3824d
Try testing on CPU then
NicolasHug 909d382
Add LD_LIBRARY_PATH
NicolasHug ff3c1f0
use cuda torch
NicolasHug 6f881d1
Merge branch 'main' of github.com:pytorch/torchcodec into add_aarch64…
NicolasHug 884d86a
Increase tol
NicolasHug ed91372
Hmm
NicolasHug c7f0785
Merge branch 'main' of github.com:pytorch/torchcodec into add_aarch64…
NicolasHug 962fcd8
Try more stuff
NicolasHug dc66a3f
arg
NicolasHug 784cf80
Merge branch 'main' of github.com:pytorch/torchcodec into add_aarch64…
NicolasHug 1c83496
Merge branch 'main' of github.com:pytorch/torchcodec into add_aarch64…
NicolasHug 0e00214
Put back old jobs
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cuda version is specified outside of the
matrix, as done inlinux_cuda_wheel. Is that intentional?torchcodec/.github/workflows/linux_cuda_wheel.yaml
Lines 63 to 72 in 957a150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - yes that's intentional. In this new job we only test on a CUDA 12.6 machine, not a any other CUDA versions (see
image: pytorch/manylinuxaarch64-builder:cuda12.6) above.We don't need to test more CUDA versions because we can't run CUDA tests on ARM anyway (that's a
test-infralimitation, from what I understand). And we still have to use a CUDA docker image because the wheels were built with CUDA support.