.NET: IHostedAgentBuilder overloads for workflows; simplify workflow extensions
#1731
Conversation
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies workflow extension methods and adds overloads for hosting extensions to accept IHostedAgentBuilder parameters. The changes eliminate the AddConcurrentWorkflow and AddSequentialWorkflow convenience methods in favor of explicit workflow configuration, while enabling callers to pass agent builders directly to mapping methods instead of repeating agent names.
Key changes:
- Removed
AddConcurrentWorkflowandAddSequentialWorkflowextension methods - Added
IHostedAgentBuilderoverloads toMapA2A,MapOpenAIChatCompletions, andMapOpenAIResponses - Updated sample code to use explicit workflow configuration and new builder-based mapping methods
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| HostApplicationBuilderWorkflowExtensionsTests.cs | Removed unit tests for deleted AddConcurrentWorkflow and AddSequentialWorkflow methods |
| HostApplicationBuilderWorkflowExtensions.cs | Deleted AddConcurrentWorkflow and AddSequentialWorkflow methods and removed unused System.Collections.Generic import |
| EndpointRouteBuilderExtensions.Responses.cs | Added IHostedAgentBuilder overloads for MapOpenAIResponses method |
| EndpointRouteBuilderExtensions.ChatCompletions.cs | Added IHostedAgentBuilder overload for MapOpenAIChatCompletions and changed return type to IEndpointConventionBuilder |
| EndpointRouteBuilderExtensions.cs | Added four new MapA2A overloads accepting IHostedAgentBuilder |
| Program.cs | Updated sample to use explicit workflow configuration and new builder-based mapping methods |
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
DeagleGross
temporarily deployed
to
integration
GitHub Actions
Inactive
There was a problem hiding this comment.
Looks ok to me, though for the builder stuff I defer to @ReubenBond
| builder.AddConcurrentWorkflow("science-concurrent-workflow", [chemistryAgent, mathsAgent, literatureAgent]).AddAsAIAgent(); | ||
| var scienceSequentialWorkflow = builder.AddWorkflow("science-sequential-workflow", (sp, key) => | ||
| { | ||
| List<IHostedAgentBuilder> usedAgents = [chemistryAgent, mathsAgent, literatureAgent]; |
There was a problem hiding this comment.
FWIW, it's still counterintuitive to me that something called "Agent" and that's returned from a method called "AddAIAgent" is actually a builder. I understand why it is, but maybe there are things we could do to ease this.
2 intentions here:
AddConcurrentWorkflowandAddSequentialWorkflowas per .NET: Add DevUI package for .NET #1603 (comment)IHostedAgentBuilder- this avoids need of copying the name of agent in registration+Map... methods.