Fix unquote #2338
Merged
Fix unquote #2338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regex misport in the UnquoteString function. The original regex incorrectly matched all dot characters (.) instead of escape sequences (backslash followed by any character \.). This caused string literals containing dots to be incorrectly transformed, e.g., "1.0" became "10".
Key Changes:
- Fixed regex pattern from
\.to\\.to properly match backslash-escaped characters - Updated 30+ test baselines showing corrected string property name handling
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/stringutil/util.go |
Fixed regex pattern to match \. (backslash + any char) instead of . (just dot) |
testdata/baselines/reference/submodule/conformance/*.symbols |
Updated baselines showing dots in property names are now preserved correctly (e.g., "1.0" instead of "10") |
testdata/baselines/reference/submodule/conformance/*.symbols.diff |
Several diff files removed or reduced, indicating convergence with TypeScript reference behavior |
testdata/baselines/reference/submodule/compiler/*.symbols |
Updated baselines for compiler tests with numeric property names containing dots |
testdata/baselines/reference/submodule/compiler/*.symbols.diff |
Diff files removed, showing alignment with expected TypeScript behavior |
jakebailey
approved these changes
Dec 11, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Why is this even a regex? 😄
DanielRosenwasser
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misported regex. Noticed in #2333 (comment).