Skip to content

Fix unquote #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabritto merged 1 commit into from
Dec 11, 2025
Merged

Fix unquote #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/stringutil/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func StripQuotes(name string) string {
return name
}

var matchSlashSomething = regexp.MustCompile(`\.`)
var matchSlashSomething = regexp.MustCompile(`\\.`)

func matchSlashReplacer(in string) string {
return in[1:]
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/classStaticPropertyAccess.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class A {
>A : Symbol(A, Decl(classStaticPropertyAccess.ts, 0, 0))

public static "\""() {}
>"\"" : Symbol(A["\\\""], Decl(classStaticPropertyAccess.ts, 0, 9))
>"\"" : Symbol(A["\""], Decl(classStaticPropertyAccess.ts, 0, 9))

public static x: number = 1;
>x : Symbol(A.x, Decl(classStaticPropertyAccess.ts, 1, 27))
Expand Down
11 changes: 0 additions & 11 deletions testdata/baselines/reference/submodule/compiler/classStaticPropertyAccess.symbols.diff
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/numericClassMembers1.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class C236 {
>C236 : Symbol(C236, Decl(numericClassMembers1.ts, 8, 1))

'0.0' = 1;
>'0.0' : Symbol(C236["00"], Decl(numericClassMembers1.ts, 10, 12))
>'0.0' : Symbol(C236["0.0"], Decl(numericClassMembers1.ts, 10, 12))

'0' = 2;
>'0' : Symbol(C236["0"], Decl(numericClassMembers1.ts, 11, 14))
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/compiler/numericClassMembers1.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

'0.0' = 1;
->'0.0' : Symbol(C236['0.0'], Decl(numericClassMembers1.ts, 10, 12))
+>'0.0' : Symbol(C236["00"], Decl(numericClassMembers1.ts, 10, 12))
+>'0.0' : Symbol(C236["0.0"], Decl(numericClassMembers1.ts, 10, 12))

'0' = 2;
->'0' : Symbol(C236['0'], Decl(numericClassMembers1.ts, 11, 14))
Expand Down
8 changes: 4 additions & 4 deletions testdata/baselines/reference/submodule/compiler/propertiesAndIndexersForNumericNames.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ class C {
>"-1" : Symbol(C["-1"], Decl(propertiesAndIndexersForNumericNames.ts, 5, 34))

public "-2.5": string = "negative number"; // Error
>"-2.5" : Symbol(C["-25"], Decl(propertiesAndIndexersForNumericNames.ts, 6, 44))
>"-2.5" : Symbol(C["-2.5"], Decl(propertiesAndIndexersForNumericNames.ts, 6, 44))

public "3.141592": string = "pi-sitive number"; // Error
>"3.141592" : Symbol(C["3141592"], Decl(propertiesAndIndexersForNumericNames.ts, 7, 46))
>"3.141592" : Symbol(C["3.141592"], Decl(propertiesAndIndexersForNumericNames.ts, 7, 46))

public "1.2e-20": string = "really small number"; // Error
>"1.2e-20" : Symbol(C["12e-20"], Decl(propertiesAndIndexersForNumericNames.ts, 8, 51))
>"1.2e-20" : Symbol(C["1.2e-20"], Decl(propertiesAndIndexersForNumericNames.ts, 8, 51))

public "Infinity": string = "A gillion"; // Error
>"Infinity" : Symbol(C["Infinity"], Decl(propertiesAndIndexersForNumericNames.ts, 9, 53))
Expand Down Expand Up @@ -94,6 +94,6 @@ class C {
>"0b101101001010" : Symbol(C["0b101101001010"], Decl(propertiesAndIndexersForNumericNames.ts, 37, 47))

public "0.000000000000000000012": string = "should've been in exponential form"; // No error
>"0.000000000000000000012" : Symbol(C["0000000000000000000012"], Decl(propertiesAndIndexersForNumericNames.ts, 38, 56))
>"0.000000000000000000012" : Symbol(C["0.000000000000000000012"], Decl(propertiesAndIndexersForNumericNames.ts, 38, 56))
}

26 changes: 0 additions & 26 deletions .../baselines/reference/submodule/compiler/propertiesAndIndexersForNumericNames.symbols.diff
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...ference/submodule/conformance/assignmentCompatWithObjectMembersStringNumericNames.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module JustStrings {

class T { '1.': string; }
>T : Symbol(T, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 4, 28))
>'1.' : Symbol(T["1"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
>'1.' : Symbol(T["1."], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))

var s: S;
>s : Symbol(s, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 6, 7))
Expand All @@ -30,7 +30,7 @@ module JustStrings {

interface T2 { '1.0': string; baz?: string }
>T2 : Symbol(T2, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 9, 46))
>'1.0' : Symbol(T2["10"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
>'1.0' : Symbol(T2["1.0"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
>baz : Symbol(T2.baz, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 33))

var s2: S2;
Expand Down
4 changes: 2 additions & 2 deletions ...ce/submodule/conformance/assignmentCompatWithObjectMembersStringNumericNames.symbols.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class T { '1.': string; }
>T : Symbol(T, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 4, 28))
->'1.' : Symbol(T['1.'], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
+>'1.' : Symbol(T["1"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))
+>'1.' : Symbol(T["1."], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 5, 13))

var s: S;
>s : Symbol(s, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 6, 7))
Expand All @@ -25,7 +25,7 @@
interface T2 { '1.0': string; baz?: string }
>T2 : Symbol(T2, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 9, 46))
->'1.0' : Symbol(T2['1.0'], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
+>'1.0' : Symbol(T2["10"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
+>'1.0' : Symbol(T2["1.0"], Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 18))
>baz : Symbol(T2.baz, Decl(assignmentCompatWithObjectMembersStringNumericNames.ts, 10, 33))

var s2: S2;
Expand Down
8 changes: 4 additions & 4 deletions ...ines/reference/submodule/conformance/numericIndexerConstrainsPropertyDeclarations.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ class C {
>2.0 : Symbol(C[2.0], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 16, 16))

"3.0": string; // ok
>"3.0" : Symbol(C["30"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 17, 16))
>"3.0" : Symbol(C["3.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 17, 16))

"4.0": number; // error
>"4.0" : Symbol(C["40"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 18, 18))
>"4.0" : Symbol(C["4.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 18, 18))

3.0: MyNumber // error
>3.0 : Symbol(C[3.0], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 19, 18))
Expand Down Expand Up @@ -116,10 +116,10 @@ interface I {
>foo : Symbol(I.foo, Decl(numericIndexerConstrainsPropertyDeclarations.ts, 51, 15))

"3.0": string; // ok
>"3.0" : Symbol(I["30"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 52, 18))
>"3.0" : Symbol(I["3.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 52, 18))

"4.0": number; // error
>"4.0" : Symbol(I["40"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 53, 18))
>"4.0" : Symbol(I["4.0"], Decl(numericIndexerConstrainsPropertyDeclarations.ts, 53, 18))

f: MyNumber; // error
>f : Symbol(I.f, Decl(numericIndexerConstrainsPropertyDeclarations.ts, 54, 18))
Expand Down
28 changes: 0 additions & 28 deletions ...reference/submodule/conformance/numericIndexerConstrainsPropertyDeclarations.symbols.diff
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions ...nes/reference/submodule/conformance/numericIndexerConstrainsPropertyDeclarations2.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ class Foo {
>B : Symbol(B, Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 4, 1))

"2.5": B // ok
>"2.5" : Symbol(Foo["25"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 13, 11))
>"2.5" : Symbol(Foo["2.5"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 13, 11))
>B : Symbol(B, Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 4, 1))

3.0: number; // error
>3.0 : Symbol(Foo[3.0], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 14, 12))

"4.0": string; // error
>"4.0" : Symbol(Foo["40"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 15, 16))
>"4.0" : Symbol(Foo["4.0"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 15, 16))
}

interface Foo2 {
Expand All @@ -60,14 +60,14 @@ interface Foo2 {
>B : Symbol(B, Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 4, 1))

"2.5": B // ok
>"2.5" : Symbol(Foo2["25"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 22, 11))
>"2.5" : Symbol(Foo2["2.5"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 22, 11))
>B : Symbol(B, Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 4, 1))

3.0: number; // error
>3.0 : Symbol(Foo2[3.0], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 23, 12))

"4.0": string; // error
>"4.0" : Symbol(Foo2["40"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 24, 16))
>"4.0" : Symbol(Foo2["4.0"], Decl(numericIndexerConstrainsPropertyDeclarations2.ts, 24, 16))
}

var a: {
Expand Down
36 changes: 0 additions & 36 deletions ...eference/submodule/conformance/numericIndexerConstrainsPropertyDeclarations2.symbols.diff
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...a/baselines/reference/submodule/conformance/numericStringNamedPropertyEquivalence.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class C {
>"1" : Symbol(C["1"], Decl(numericStringNamedPropertyEquivalence.ts, 2, 9), Decl(numericStringNamedPropertyEquivalence.ts, 4, 18))

"1.0": number; // not a duplicate
>"1.0" : Symbol(C["10"], Decl(numericStringNamedPropertyEquivalence.ts, 3, 16))
>"1.0" : Symbol(C["1.0"], Decl(numericStringNamedPropertyEquivalence.ts, 3, 16))

1.0: number;
>1.0 : Symbol(C["1"], Decl(numericStringNamedPropertyEquivalence.ts, 2, 9), Decl(numericStringNamedPropertyEquivalence.ts, 4, 18))
Expand All @@ -23,7 +23,7 @@ interface I {
>"1" : Symbol(I["1"], Decl(numericStringNamedPropertyEquivalence.ts, 8, 13), Decl(numericStringNamedPropertyEquivalence.ts, 10, 17))

"1.": number; // not a duplicate
>"1." : Symbol(I["1"], Decl(numericStringNamedPropertyEquivalence.ts, 9, 16))
>"1." : Symbol(I["1."], Decl(numericStringNamedPropertyEquivalence.ts, 9, 16))

1: number;
>1 : Symbol(I["1"], Decl(numericStringNamedPropertyEquivalence.ts, 8, 13), Decl(numericStringNamedPropertyEquivalence.ts, 10, 17))
Expand Down
20 changes: 0 additions & 20 deletions ...elines/reference/submodule/conformance/numericStringNamedPropertyEquivalence.symbols.diff
View file
Open in desktop

This file was deleted.

Loading