Skip to content

Conversation

@anatawa12
Copy link
Member

What

biomejsをlinterとして使う実験を行いました。

コーディングスタイル周りは biomejs は prettier と同様に opinioned なのでどうしようか悩んでます

Why

linterが遅いからそれの改善

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Semi-automated changes:
- '@relation(type => ' => '@relation(() => '
- 'catch (err)' => 'catch(_)' where unused
- remove variable where suitable
- prefix with _ otherwise
- lint/complexity/useDateNow
- lint/complexity/useIndexOf
- lint/complexity/useOptionalChain
- lint/complexity/noStaticOnlyClass (disabled)
- lint/complexity/noCommaOperator
- lint/complexity/noUselessConstructor
- lint/suspicious/noConfusingVoidType (partially suppressed)
- lint/suspicious/noDoubleEquals
- lint/suspicious/noImplicitAnyLet
- lint/suspicious/noAsyncPromiseExecutor
- lint/suspicious/noFallthroughSwitchClause
scroll.test.ts: should we use document? or window.document?
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -5112,7 +5112,7 @@
                       "string",
                       "null"
                     ],
-                    "pattern": "^[a-zA-Z0-9\\/\\-*]+$"
+                    "pattern": "^[a-zA-Z0-9/\\-*]+$"
                   },
                   "origin": {
                     "type": "string",
@@ -39052,7 +39052,7 @@
                       "string",
                       "null"
                     ],
-                    "pattern": "^[a-zA-Z\\/\\-*]+$"
+                    "pattern": "^[a-zA-Z/\\-*]+$"
                   },
                   "sort": {
                     "type": [
@@ -42337,7 +42337,7 @@
                   },
                   "type": {
                     "type": "string",
-                    "pattern": "^[a-zA-Z\\/\\-*]+$"
+                    "pattern": "^[a-zA-Z/\\-*]+$"
                   }
                 }
               }
@@ -74628,7 +74628,7 @@
                   },
                   "name": {
                     "type": "string",
-                    "pattern": "^[^\\s:\\/?#\\[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
+                    "pattern": "^[^\\s:/?#[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
                     "minLength": 1
                   },
                   "summary": {
@@ -75699,7 +75699,7 @@
                   },
                   "name": {
                     "type": "string",
-                    "pattern": "^[^\\s:\\/?#\\[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
+                    "pattern": "^[^\\s:/?#[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
                     "minLength": 1
                   },
                   "summary": {

Get diff files from Workflow Page

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

Backend Memory Usage Comparison

Metric base head Diff
RSS 359.24 MB 352.07 MB -7.16 MB (-1.99%)

See workflow logs for details

@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 91.94699% with 158 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.13%. Comparing base (d74aded) to head (d90fa45).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/core/activitypub/ApInboxService.ts 53.48% 20 Missing ⚠️
packages/backend/src/boot/master.ts 0.00% 9 Missing ⚠️
packages/backend/src/core/ReversiService.ts 55.00% 9 Missing ⚠️
packages/backend/src/core/FanoutTimelineService.ts 38.46% 8 Missing ⚠️
...end/src/core/activitypub/models/ApPersonService.ts 84.44% 7 Missing ⚠️
packages/backend/src/models/Notification.ts 0.00% 7 Missing ⚠️
.../backend/src/core/activitypub/ApRendererService.ts 77.27% 5 Missing ⚠️
...ackages/backend/src/queue/QueueProcessorService.ts 84.84% 5 Missing ⚠️
packages/backend/src/NestLogger.ts 33.33% 4 Missing ⚠️
packages/backend/src/core/DriveService.ts 87.50% 4 Missing ⚠️
... and 44 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16983      +/-   ##
===========================================
+ Coverage    62.84%   68.13%   +5.29%     
===========================================
  Files         1150      913     -237     
  Lines       115224   103713   -11511     
  Branches      7893     4172    -3721     
===========================================
- Hits         72407    70660    -1747     
+ Misses       40658    33013    -7645     
+ Partials      2159       40    -2119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@u1-liquid
Copy link
Contributor

u1-liquid commented Dec 14, 2025

useEditorconfig設定するのおすすめです
https://github.com/MisskeyIO/misskey/pull/823/changes#diff-2bc8a1f5e9380d5a187a4e90f11b4dd36c3abad6aea44c84be354a4f44cdec55R13-R17

@anatawa12
Copy link
Member Author

preferがundefinedになってるという問題になってますが、esmoduleの仕様からしてそうはならないのでvitestのバグを踏んでる...?

@u1-liquid
Copy link
Contributor

preferがundefinedになってる

以前ioのフォークで試した際にorganizeImportsの順番でaccount.tsの$iに対してReferenceErrorが発生するケースを確認してますので、同じケースかもしれません
MisskeyIO#823 (comment)

@anatawa12
Copy link
Member Author

recursive importの処理あたりなのかなぁ...情報ありがとうございます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants