-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
experiment: use biome as the linter #16983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…TypeReturn noExportsInTest
- lint/complexity/useDateNow - lint/complexity/useIndexOf - lint/complexity/useOptionalChain - lint/complexity/noStaticOnlyClass (disabled) - lint/complexity/noCommaOperator - lint/complexity/noUselessConstructor
- lint/suspicious/noConfusingVoidType (partially suppressed) - lint/suspicious/noDoubleEquals - lint/suspicious/noImplicitAnyLet - lint/suspicious/noAsyncPromiseExecutor - lint/suspicious/noFallthroughSwitchClause
scroll.test.ts: should we use document? or window.document?
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -5112,7 +5112,7 @@
"string",
"null"
],
- "pattern": "^[a-zA-Z0-9\\/\\-*]+$"
+ "pattern": "^[a-zA-Z0-9/\\-*]+$"
},
"origin": {
"type": "string",
@@ -39052,7 +39052,7 @@
"string",
"null"
],
- "pattern": "^[a-zA-Z\\/\\-*]+$"
+ "pattern": "^[a-zA-Z/\\-*]+$"
},
"sort": {
"type": [
@@ -42337,7 +42337,7 @@
},
"type": {
"type": "string",
- "pattern": "^[a-zA-Z\\/\\-*]+$"
+ "pattern": "^[a-zA-Z/\\-*]+$"
}
}
}
@@ -74628,7 +74628,7 @@
},
"name": {
"type": "string",
- "pattern": "^[^\\s:\\/?#\\[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
+ "pattern": "^[^\\s:/?#[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
"minLength": 1
},
"summary": {
@@ -75699,7 +75699,7 @@
},
"name": {
"type": "string",
- "pattern": "^[^\\s:\\/?#\\[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
+ "pattern": "^[^\\s:/?#[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
"minLength": 1
},
"summary": { |
Backend Memory Usage Comparison
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #16983 +/- ##
===========================================
+ Coverage 62.84% 68.13% +5.29%
===========================================
Files 1150 913 -237
Lines 115224 103713 -11511
Branches 7893 4172 -3721
===========================================
- Hits 72407 70660 -1747
+ Misses 40658 33013 -7645
+ Partials 2159 40 -2119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
preferがundefinedになってるという問題になってますが、esmoduleの仕様からしてそうはならないのでvitestのバグを踏んでる...? |
以前ioのフォークで試した際にorganizeImportsの順番でaccount.tsの$iに対してReferenceErrorが発生するケースを確認してますので、同じケースかもしれません |
|
recursive importの処理あたりなのかなぁ...情報ありがとうございます。 |
What
biomejsをlinterとして使う実験を行いました。
コーディングスタイル周りは biomejs は prettier と同様に opinioned なのでどうしようか悩んでます
Why
linterが遅いからそれの改善
Additional info (optional)
Checklist