Skip to content

Conversation

@A1pine
Copy link
Contributor

@A1pine A1pine commented Sep 23, 2025

fix: correct deepspeed_config path reference error
Resolved incorrect path reference in DeepSpeed configuration
from:

  • ${workspace}/../../ds_stage1.json
    to:
  • ${workspace}/../../deepspeed_conf/ds_stage1.json

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @A1pine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical pathing issue within the finetuning script for the Paraformer model. By updating the deepspeed_config variable to point to the correct subdirectory, it resolves a potential runtime error that would prevent the DeepSpeed configuration from being loaded, thereby enabling the finetuning process to execute successfully.

Highlights

  • DeepSpeed Configuration Path: Corrected an incorrect path reference for the DeepSpeed configuration file in the finetuning script, ensuring the script can locate ds_stage1.json within the deepspeed_conf directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects an invalid path to the DeepSpeed configuration file in the finetune.sh script. The fix is correct and ensures the script can find the configuration when DeepSpeed is enabled. I have one suggestion to improve the code's robustness by quoting the path assignment, which is a common best practice in shell scripting and consistent with other variable assignments in this file.

log_file="${output_dir}/log.txt"

deepspeed_config=${workspace}/../../ds_stage1.json
deepspeed_config=${workspace}/../../deepspeed_conf/ds_stage1.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variable assignments in this script (e.g., log_file, train_data) and for general robustness, it's good practice to enclose the path in double quotes. This prevents potential issues if the path were to contain spaces or other special characters, which is a recommended practice in shell scripting to avoid unexpected word splitting.

Suggested change
deepspeed_config=${workspace}/../../deepspeed_conf/ds_stage1.json
deepspeed_config="${workspace}/../../deepspeed_conf/ds_stage1.json"

@LauraGPT LauraGPT merged commit 8c6d164 into modelscope:main Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants