Skip to content

fix: correct the deepspeed_config path reference in the finetuning script #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix: correct the deepspeed_config path reference in the finetuning script #2680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/industrial_data_pretraining/paraformer/finetune.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ scp2jsonl \
output_dir="./outputs"
log_file="${output_dir}/log.txt"

deepspeed_config=${workspace}/../../ds_stage1.json
deepspeed_config=${workspace}/../../deepspeed_conf/ds_stage1.json
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variable assignments in this script (e.g., log_file, train_data) and for general robustness, it's good practice to enclose the path in double quotes. This prevents potential issues if the path were to contain spaces or other special characters, which is a recommended practice in shell scripting to avoid unexpected word splitting.

Suggested change
deepspeed_config=${workspace}/../../deepspeed_conf/ds_stage1.json
deepspeed_config="${workspace}/../../deepspeed_conf/ds_stage1.json"


mkdir -p ${output_dir}
echo "log_file: ${log_file}"
Expand Down