[LG-5464] chore(code-editor): remove unused dependencies and standardize test syntax #3065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR performs comprehensive cleanup and standardization tasks on the CodeEditor package to improve code quality and maintainability. The changes include removing unused dependencies, standardizing test syntax across the codebase, and setting up proper TypeScript configuration for the new package.
Key improvements:
- Package registration: Added CodeEditor to the ALL_PACKAGES list for proper installation tooling
- TypeScript configuration: Set up comprehensive tsconfig.json with proper paths and references
- Test standardization: Updated all test files to use
test()instead ofit()for consistency with project conventions - Complete component implementation: Added full CodeEditor implementation with hooks, extensions, formatting capabilities, and comprehensive test coverage
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/install/src/ALL_PACKAGES.ts | Registers code-editor package in installation tooling |
| packages/code-editor/tsconfig.json | Complete TypeScript configuration with dependencies and paths |
| packages/code-editor/src/index.ts | Main package exports for public API |
| packages/code-editor/src/Panel/* | Panel component with comprehensive props, styling, and tests |
| packages/code-editor/src/CodeEditorCopyButton* | Copy button components with clipboard functionality and tests |
| packages/code-editor/src/CodeEditor/* | Core editor implementation with hooks, extensions, and test utilities |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
Size Change: 0 B Total Size: 2.03 MB ℹ️ View Unchanged
|
stephl3
approved these changes
Aug 22, 2025
tsck
force-pushed
the
LG-5129/ce-undo-redo
branch
from
981bdc5 to
697843a
Compare
tsck
force-pushed
the
LG-5464/ce-cleanup
branch
from
08f40b0 to
d1d676f
Compare
Base automatically changed from
LG-5129/ce-undo-redo
to
integration/code-editor
August 28, 2025 16:30
tsck
force-pushed
the
integration/code-editor
branch
from
e5f6ed4 to
cb2fe2e
Compare
tsck
force-pushed
the
LG-5464/ce-cleanup
branch
from
98a1647 to
0568216
Compare
- Replaced all instances of 'it' with 'test' in the test files for consistency across the codebase. - This change improves readability and aligns with the preferred testing syntax in the project.
- Removed '@uiw/react-codemirror' from package.json and pnpm-lock.yaml as it is no longer needed. - Cleaned up imports in useThemeExtension.ts to eliminate references to the removed dependency. - Updated testUtils.tsx to use ChangeSpec from '@codemirror/state' instead of the removed '@uiw/react-codemirror'.
tsck
force-pushed
the
LG-5464/ce-cleanup
branch
from
0568216 to
878344d
Compare
tsck
added a commit
that referenced
this pull request
Aug 29, 2025
…ize test syntax (#3065) * refactor(tests): update test cases to use 'test' instead of 'it' - Replaced all instances of 'it' with 'test' in the test files for consistency across the codebase. - This change improves readability and aligns with the preferred testing syntax in the project. * chore: remove unused Codemirror dependencies and clean up imports - Removed '@uiw/react-codemirror' from package.json and pnpm-lock.yaml as it is no longer needed. - Cleaned up imports in useThemeExtension.ts to eliminate references to the removed dependency. - Updated testUtils.tsx to use ChangeSpec from '@codemirror/state' instead of the removed '@uiw/react-codemirror'.
tsck
added a commit
that referenced
this pull request
Sep 15, 2025
…ize test syntax (#3065) * refactor(tests): update test cases to use 'test' instead of 'it' - Replaced all instances of 'it' with 'test' in the test files for consistency across the codebase. - This change improves readability and aligns with the preferred testing syntax in the project. * chore: remove unused Codemirror dependencies and clean up imports - Removed '@uiw/react-codemirror' from package.json and pnpm-lock.yaml as it is no longer needed. - Cleaned up imports in useThemeExtension.ts to eliminate references to the removed dependency. - Updated testUtils.tsx to use ChangeSpec from '@codemirror/state' instead of the removed '@uiw/react-codemirror'.
tsck
added a commit
that referenced
this pull request
Sep 16, 2025
…ize test syntax (#3065) * refactor(tests): update test cases to use 'test' instead of 'it' - Replaced all instances of 'it' with 'test' in the test files for consistency across the codebase. - This change improves readability and aligns with the preferred testing syntax in the project. * chore: remove unused Codemirror dependencies and clean up imports - Removed '@uiw/react-codemirror' from package.json and pnpm-lock.yaml as it is no longer needed. - Cleaned up imports in useThemeExtension.ts to eliminate references to the removed dependency. - Updated testUtils.tsx to use ChangeSpec from '@codemirror/state' instead of the removed '@uiw/react-codemirror'.
tsck
added a commit
that referenced
this pull request
Sep 16, 2025
…ize test syntax (#3065) * refactor(tests): update test cases to use 'test' instead of 'it' - Replaced all instances of 'it' with 'test' in the test files for consistency across the codebase. - This change improves readability and aligns with the preferred testing syntax in the project. * chore: remove unused Codemirror dependencies and clean up imports - Removed '@uiw/react-codemirror' from package.json and pnpm-lock.yaml as it is no longer needed. - Cleaned up imports in useThemeExtension.ts to eliminate references to the removed dependency. - Updated testUtils.tsx to use ChangeSpec from '@codemirror/state' instead of the removed '@uiw/react-codemirror'.
tsck
added a commit
that referenced
this pull request
Sep 18, 2025
…ize test syntax (#3065) * refactor(tests): update test cases to use 'test' instead of 'it' - Replaced all instances of 'it' with 'test' in the test files for consistency across the codebase. - This change improves readability and aligns with the preferred testing syntax in the project. * chore: remove unused Codemirror dependencies and clean up imports - Removed '@uiw/react-codemirror' from package.json and pnpm-lock.yaml as it is no longer needed. - Cleaned up imports in useThemeExtension.ts to eliminate references to the removed dependency. - Updated testUtils.tsx to use ChangeSpec from '@codemirror/state' instead of the removed '@uiw/react-codemirror'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR performs cleanup tasks on the CodeEditor package to improve code quality and maintainability. The changes include removing unused dependencies that were previously part of the CodeMirror integration and standardizing test syntax across the codebase.
Key improvements:
@uiw/react-codemirrorand related packages that are no longer needed after recent CodeMirror integration changestest()instead ofit()for consistency with the project's testing conventionsThese changes reduce bundle size, eliminate potential security vulnerabilities from unused dependencies, and improve code consistency across the test suite.
🎟 Jira ticket: LG-5464
🧪 How to test changes
yarn testin thepackages/code-editordirectory to ensure all test cases continue to function correctly with thetest()syntaxyarn fix:eslintto confirm that the standardized test syntax passes linting rules