PYTHON-5444 Update OIDC tests use camelCase options #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyclements
requested changes
Jul 16, 2025
| @@ -1119,7 +1119,7 @@ async def test_5_2_azure_with_bad_username(self): | |||
| raise unittest.SkipTest("Test is only supported on Azure") | |||
|
|
|||
| opts = parse_uri(self.uri_single)["options"] | |||
| token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"] | |||
| token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"] | |||
|
|
|||
| props = dict(TOKEN_RESOURCE=token_aud, ENVIRONMENT="azure") | |||
| client = await self.create_client(username="bad", authmechanismproperties=props) | |||
There was a problem hiding this comment.
Missed kwarg here. It's inconsistent with line 1114.
There was a problem hiding this comment.
These aren't subject to normalization rules.
There was a problem hiding this comment.
Still. It feels like consistency would be helpful. create_client pops "authmechanismproperties" from kwargs, but in the docstring for MongoClient, the kwarg is authMechanismProperties.
There was a problem hiding this comment.
That value was set elsewhere, I wanted to make the smallest change possible for this PR
There was a problem hiding this comment.
Because testing OIDC is expensive (time and compute-wise)
| @@ -1117,7 +1117,7 @@ def test_5_2_azure_with_bad_username(self): | |||
| raise unittest.SkipTest("Test is only supported on Azure") | |||
|
|
|||
| opts = parse_uri(self.uri_single)["options"] | |||
| token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"] | |||
| token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"] | |||
|
|
|||
| props = dict(TOKEN_RESOURCE=token_aud, ENVIRONMENT="azure") | |||
| client = self.create_client(username="bad", authmechanismproperties=props) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing build: https://spruce.mongodb.com/version/6877c6284320e70007aa831f/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC