Skip to content

PYTHON-5444 Update OIDC tests use camelCase options #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

PYTHON-5444 Update OIDC tests use camelCase options #2436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/asynchronous/test_auth_oidc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ def get_token(self, username=None):
return fid.read()
elif ENVIRON == "azure":
opts = parse_uri(self.uri_single)["options"]
token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"]
return _get_azure_response(token_aud, username)["access_token"]
elif ENVIRON == "gcp":
opts = parse_uri(self.uri_single)["options"]
token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"]
return _get_gcp_response(token_aud, username)["access_token"]
elif ENVIRON == "k8s":
return _get_k8s_token()
Expand Down Expand Up @@ -1108,7 +1108,7 @@ async def test_5_1_azure_with_no_username(self):
if ENVIRON != "azure":
raise unittest.SkipTest("Test is only supported on Azure")
opts = parse_uri(self.uri_single)["options"]
resource = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
resource = opts["authMechanismProperties"]["TOKEN_RESOURCE"]

props = dict(TOKEN_RESOURCE=resource, ENVIRONMENT="azure")
client = await self.create_client(authMechanismProperties=props)
Expand All @@ -1119,7 +1119,7 @@ async def test_5_2_azure_with_bad_username(self):
raise unittest.SkipTest("Test is only supported on Azure")

opts = parse_uri(self.uri_single)["options"]
token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"]

props = dict(TOKEN_RESOURCE=token_aud, ENVIRONMENT="azure")
client = await self.create_client(username="bad", authmechanismproperties=props)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed kwarg here. It's inconsistent with line 1114.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't subject to normalization rules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still. It feels like consistency would be helpful. create_client pops "authmechanismproperties" from kwargs, but in the docstring for MongoClient, the kwarg is authMechanismProperties.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That value was set elsewhere, I wanted to make the smallest change possible for this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because testing OIDC is expensive (time and compute-wise)

Expand Down
8 changes: 4 additions & 4 deletions test/test_auth_oidc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ def get_token(self, username=None):
return fid.read()
elif ENVIRON == "azure":
opts = parse_uri(self.uri_single)["options"]
token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"]
return _get_azure_response(token_aud, username)["access_token"]
elif ENVIRON == "gcp":
opts = parse_uri(self.uri_single)["options"]
token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"]
return _get_gcp_response(token_aud, username)["access_token"]
elif ENVIRON == "k8s":
return _get_k8s_token()
Expand Down Expand Up @@ -1106,7 +1106,7 @@ def test_5_1_azure_with_no_username(self):
if ENVIRON != "azure":
raise unittest.SkipTest("Test is only supported on Azure")
opts = parse_uri(self.uri_single)["options"]
resource = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
resource = opts["authMechanismProperties"]["TOKEN_RESOURCE"]

props = dict(TOKEN_RESOURCE=resource, ENVIRONMENT="azure")
client = self.create_client(authMechanismProperties=props)
Expand All @@ -1117,7 +1117,7 @@ def test_5_2_azure_with_bad_username(self):
raise unittest.SkipTest("Test is only supported on Azure")

opts = parse_uri(self.uri_single)["options"]
token_aud = opts["authmechanismproperties"]["TOKEN_RESOURCE"]
token_aud = opts["authMechanismProperties"]["TOKEN_RESOURCE"]

props = dict(TOKEN_RESOURCE=token_aud, ENVIRONMENT="azure")
client = self.create_client(username="bad", authmechanismproperties=props)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again.

Expand Down
Loading