Set last_known_joypad_device to "" when no joypad initially connected #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring for last_known_joypad_device claims that its value is "" if no joypad is detected, but previously its value in this case was "generic", because it is defined to be the result of get_simplified_device_name() on the 0th joypad's name. If there is no joypad connected, Input.get_joy_name(0) returns "", but get_simplified_device_name() returns "generic" in the case where it can't figure out what a joypad is (such as when it is passed "").
When initialising the variable, check whether any joypads are connected, and special-case the default as "" if not. This matches how the default value of last_known_joypad_index below it is set.