fix: misleading mesesage in select field during wp creation #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
fix/options
branch
2 times, most recently
from
8419056 to
02be993
Compare
Signed-off-by: nabim777 <[email protected]>
nabim777
requested review from
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
psatyal,
saw-jan and
wielinde
as code owners
saw-jan
reviewed
Dec 3, 2025
src/views/CreateWorkPackageModal.vue
Outdated
| if (this.project.label === null) { | ||
| return t('integration_openproject', 'Please select a project first!') | ||
| } | ||
| return t('integration_openproject', `No matching ${fieldName} found!`) |
Collaborator
There was a problem hiding this comment.
fieldName is not translatable. Please use messages store.
https://github.com/nextcloud/integration_openproject/blob/master/src/constants/messages.js
src/views/CreateWorkPackageModal.vue
Outdated
Comment on lines
620
to
623
| if (this.project.label === null) { | ||
| return t('integration_openproject', 'Please select a project first!') | ||
| } | ||
| return t('integration_openproject', `No matching ${fieldName} found!`) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (this.project.label === null) { | |
| return t('integration_openproject', 'Please select a project first!') | |
| } | |
| return t('integration_openproject', `No matching ${fieldName} found!`) | |
| if (this.project.label === null) { | |
| return message.pleaseSelectProject | |
| } | |
| if (fieldName === 'status') { | |
| return message.noMatchingStatusFound | |
| } else if (fieldName === 'type') { | |
| return message.noMatchingTypeFound | |
| } | |
| ... |
CHANGELOG.md
Outdated
| ### Fixed | ||
| - Fix: Work package creation with a non-existent project [#923](https://github.com/nextcloud/integration_openproject/pull/923) | ||
| - Fix: Project Value in the field could not be removed [#923](https://github.com/nextcloud/integration_openproject/pull/923) | ||
| - Fix: misleading mesesage in select field during wp creation [#924] (https://github.com/nextcloud/integration_openproject/pull/924) |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Fix: misleading mesesage in select field during wp creation [#924] (https://github.com/nextcloud/integration_openproject/pull/924) | |
| - Fix: Misleading mesesage in select field during wp creation [#924] (https://github.com/nextcloud/integration_openproject/pull/924) |
| }) | ||
|
|
||
| const input = wrapper.find(inputSelector) | ||
| await input.setValue('non-existent-assignee') |
Collaborator
There was a problem hiding this comment.
Suggested change
| await input.setValue('non-existent-assignee') | |
| await input.setValue('non-existent-search') |
Signed-off-by: nabim777 <[email protected]>
nabim777
force-pushed
the
fix/options
branch
3 times, most recently
from
34867dd to
da691d3
Compare
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
saw-jan
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a misleading message that appears in the option field, such as
type,status,assigneeduring work package creation.Steps to reproduce
Step 1: Open the work package creation model
Step 2: Fill up the project field
Step 3: In type field, try to fill with value that does not exist (you can try notexist)
Related Issue or Workpackage
Screenshots (if appropriate):
Before
when the project field is filled, then fill up the
type,statusandassigneewith notexist valueAfter
when the project field is filled, then fill up the
type,statusandassigneewith notexist valueTypes of changes
Checklist:
CHANGELOG.mdfile