Message threads #5067
Merged
Message threads #5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
feature/noid/messageThreads
branch
2 times, most recently
from
28963c5 to
ee8c507
Compare
mahibi
force-pushed
the
feature/noid/messageThreads
branch
4 times, most recently
from
3173350 to
0c6e406
Compare
mahibi
force-pushed
the
feature/noid/messageThreads
branch
4 times, most recently
from
c5e589d to
b9dc206
Compare
for now only added logic in IncomingTextMessageViewHolder.kt ... - add thread button for quoted messages if thread of message != current thread - open a new ChatActivity when clicked the button and pass threadId - change the title - add todos for now, the parentId was taken instead of topmostParentId (which is not available yet) Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
(cascade delete in migration fails for now) Signed-off-by: Marcel Hibbe <[email protected]>
Foreign key constraints are not active during migration.
At least db.execSQL("PRAGMA foreign_keys=ON;") etc did not help.
Because of this it is not enough to just clear the Conversations table (to have cascade deletion in
other tables), but all related tables have to be cleared with SQL statement as well.
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
show first and last message as thread and only the date Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
threadId was not set for temp message... Signed-off-by: Marcel Hibbe <[email protected]>
i'm not yet sure about it and did not have a problem with it, but i guess this change makes sense to ensure temporary messages from a thread are not shown and remain in the main chat. This could theoretically happen when directly leaving a thread after sending a message? Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
|
Has some conflicts, but otherwise this can be merged to get it into the testing alpha versions |
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
feature/noid/messageThreads
branch
from
b9dc206 to
68a33ef
Compare
Signed-off-by: Marcel Hibbe <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5067-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3074
This PR is not complete and contains bugs but it will be merged to master for early testing in alpha channel.
There will be followup PRs for threads support.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x