Chore: add dependabot and update psalm to v6 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
marcelklehr
reviewed
Jun 25, 2025
| @@ -20,7 +20,7 @@ or any place where the smart picker is integrated.]]></description> | |||
| <screenshot>https://github.com/julien-nc/text_templates/raw/main/img/screenshot3.jpg</screenshot> | |||
| <screenshot>https://github.com/julien-nc/text_templates/raw/main/img/screenshot4.jpg</screenshot> | |||
| <dependencies> | |||
| <nextcloud min-version="26" max-version="31"/> | |||
| <nextcloud min-version="26" max-version="32"/> | |||
There was a problem hiding this comment.
min version needs to be adjusted as well, if we drop php 8.0
There was a problem hiding this comment.
Do we need to drop 8.0 here? I just adapted the composer config but left it in the require list, the tests seem fine
There was a problem hiding this comment.
The psalm action only runs with Php 8.4 (the biggest supported one). I think Marcel means that Psalm 6.12 does not support Php 8.0 anymore so the min Nextcloud version of the app should be bumped to the first one that drops support for Php 8.0 (NC 30).
Could you use the psalm-matrix action from the company templates here?
There was a problem hiding this comment.
I think Psalm 6.12 cannot run with 8.0 but it can target 8.0 so I'd say it`s fine?
janepie
force-pushed
the
chore/add-dependabot-psalm6
branch
2 times, most recently
from
94b17fe to
a8da83e
Compare
Signed-off-by: Jana Peper <[email protected]>
janepie
force-pushed
the
chore/add-dependabot-psalm6
branch
from
a8da83e to
0bc3682
Compare
Signed-off-by: Jana Peper <[email protected]>
janepie
force-pushed
the
chore/add-dependabot-psalm6
branch
from
e73b4e1 to
2ca3946
Compare
julien-nc
force-pushed
the
chore/add-dependabot-psalm6
branch
2 times, most recently
from
6e8415e to
10ca78c
Compare
julien-nc
approved these changes
Jun 26, 2025
janepie
force-pushed
the
chore/add-dependabot-psalm6
branch
from
10ca78c to
2ca3946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.