Skip to content

Conversation

@maxulysse
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@maxulysse maxulysse changed the title lint + polish controlfreec lint + code polish controlfreec Aug 19, 2025
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is an abomination.
I have no further useful comments.

@FriederikeHanssen
Copy link
Contributor

This module is an abomination.
I have no further useful comments.

I deeply apologies @SPPearce I had no better idea at the time

@SPPearce
Copy link
Contributor

SPPearce commented Sep 8, 2025

This module is an abomination.
I have no further useful comments.

I deeply apologies @SPPearce I had no better idea at the time

It isn't your fault that the underlying tool is really hard to configure!

@FriederikeHanssen FriederikeHanssen requested review from a team as code owners September 8, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants