Fix bug with probeset and index mismatch when using cellranger multi with a probeset and without a pre-built index #502
+229
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2025 15:19
…, update tests accordingly
tgelafr-pfzr
force-pushed
the
bug/375-cellranger-multi-index-mm
branch
from
840a5f4 to
81cf3be
Compare
added 8 commits
October 30, 2025 15:21
This reverts commit 81cf3be.
nictru
reviewed
Nov 14, 2025
Contributor
nictru
left a comment
nictru
left a comment
There was a problem hiding this comment.
Looks generally good, just one minor thing
However, I personally can only check if the code is good from an nf-core perspective, as I have never worked with cellranger multi
Co-authored-by: Nico Trummer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #375.
I chose to enforce that the user manually pass the genome version to keep some sort of front-loaded check on the reference matching the probeset.
Updated tests accordingly.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.CHANGELOG.mdis updated.