Skip to content

Run functional and NFR tests with --race #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025
Merged

Run functional and NFR tests with --race #3614

merged 4 commits into from
Jul 14, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jul 10, 2025

Problem: The functional and NFR tests do not run with --race enabled, so race conditions within the tests may be present and unknown.

Solution: Enable --race and fix any issues.

Testing: Verified that all tests run.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #1857

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: The functional and NFR tests do not run with --race enabled, so race conditions within the tests may be present and unknown.

Solution: Enable --race and fix any issues.
@sjberman sjberman requested a review from a team as a code owner July 10, 2025 17:47
@github-actions github-actions bot added the tests Pull requests that update tests label Jul 10, 2025
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (e88fbeb) to head (3595791).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
- Coverage   86.91%   86.87%   -0.04%     
==========================================
  Files         127      127              
  Lines       15287    15287              
  Branches       62       62              
==========================================
- Hits        13286    13281       -5     
- Misses       1847     1851       +4     
- Partials      154      155       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman closed this Jul 10, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 10, 2025
@sjberman sjberman reopened this Jul 10, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in NGINX Gateway Fabric Jul 10, 2025
@sjberman sjberman marked this pull request as draft July 10, 2025 18:29
@sjberman sjberman marked this pull request as ready for review July 10, 2025 19:23
@sjberman sjberman enabled auto-merge (squash) July 11, 2025 21:21
@sjberman sjberman requested a review from salonichf5 July 13, 2025 15:11
@sjberman sjberman disabled auto-merge July 13, 2025 15:11
@sjberman sjberman merged commit f8ee6d1 into main Jul 14, 2025
43 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 14, 2025
@sjberman sjberman deleted the tests/race branch July 14, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Run functional and NFR tests with --race
3 participants