Skip to content

Conversation

@mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Oct 16, 2025

What does this Pull Request accomplish?

  • Added ReadAnalogWaveforms method to the NiDAQmxService.
  • Updated code generation with support for CustomCodeNoLibrary. This is needed for ReadAnalogWaveforms because it doesn't have a matching library function. (Instead, it calls library_->InternalReadAnalogWaveformPerChan(), which has very different parameters)
  • Introduced new waveform attributes and functions in metadata.
  • Updated CMake build process to include new waveform protobuf files.
  • Added Ninja build instructions to CONTRIBUTING.md.

Why should this Pull Request be merged?

AB#3424627

What testing has been done?

PS C:\dev\fireserp\grpc-device> .\build\Debug\SystemTestsRunner.exe --gtest_filter="*ReadAnalogWaveforms*"                                                             
Note: Google Test filter = *ReadAnalogWaveforms*
[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from NiDAQmxDriverApiTests
[ RUN      ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithNoAttributeMode_ReturnsWaveformData
[       OK ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithNoAttributeMode_ReturnsWaveformData (4493 ms)
[ RUN      ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithTimingMode_ReturnsWaveformDataWithTimingInfo
[       OK ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithTimingMode_ReturnsWaveformDataWithTimingInfo (128 ms)
[ RUN      ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithExtendedPropertiesMode_ReturnsWaveformDataWithAttributes
[       OK ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithExtendedPropertiesMode_ReturnsWaveformDataWithAttributes (15 ms)
[ RUN      ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithTimingAndExtendedPropertiesMode_ReturnsWaveformDataWithTimingAndAttributes
[       OK ] NiDAQmxDriverApiTests.ReadAnalogWaveforms_WithTimingAndExtendedPropertiesMode_ReturnsWaveformDataWithTimingAndAttributes (81 ms)
[----------] 4 tests from NiDAQmxDriverApiTests (4746 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test suite ran. (4754 ms total)
[  PASSED  ] 4 tests.

Mike Prosser added 5 commits October 16, 2025 13:32
- Added ReadAnalogWaveforms method stub to NiDAQmxService for reading analog waveforms.
- Updated metadata validation to include CustomCodeNoLibrary.
- Introduced new waveform attributes and functions in metadata.
- Enhanced CMake configuration for new protobuf files.
- Improved CONTRIBUTING.md with Ninja build instructions.
@mikeprosserni mikeprosserni changed the title [Under Construction] Add ReadAnalogWaveforms to NiDAQmxService Add ReadAnalogWaveforms to NiDAQmxService Oct 16, 2025
@mikeprosserni mikeprosserni marked this pull request as ready for review October 20, 2025 17:07
Copy link
Contributor

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review the actual code today. So far I've only looked at the build problems.

@mikeprosserni mikeprosserni requested a review from bkeryan October 24, 2025 20:17
@mikeprosserni mikeprosserni requested a review from bkeryan October 27, 2025 20:14
@mikeprosserni mikeprosserni requested a review from bkeryan October 28, 2025 15:56
Copy link
Contributor

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions (remove param.fraction)

@mikeprosserni mikeprosserni merged commit 65a61d6 into main Oct 28, 2025
9 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/task-3424627-read-analog-waveforms branch October 28, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants