sea: implement execArgvExtension #59560
Merged
+372
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
joyeecheung
force-pushed
the
sea-exec-argv-extension
branch
from
6c83973 to
a84a237
Compare
This implements the execArgvExtension configuration field for SEA, which takes one of three string values to specify whether and how execution arguments can be extended for the SEA at run time: * `"none"`: No extension is allowed. Only the arguments specified in `execArgv` will be used, and the `NODE_OPTIONS` environment variable will be ignored. * `"env"`: _(Default)_ The `NODE_OPTIONS` environment variable can extend the execution arguments. This is the default behavior to maintain backward compatibility. * `"cli"`: The executable can be launched with `--node-options="--flag1 --flag2"`, and those flags will be parsed as execution arguments for Node.js instead of being passed to the user script. This allows using arguments that are not supported by the `NODE_OPTIONS` environment variable.
joyeecheung
force-pushed
the
sea-exec-argv-extension
branch
from
a84a237 to
541dc75
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59560 +/- ##
========================================
Coverage 89.87% 89.88%
========================================
Files 664 667 +3
Lines 194946 195278 +332
Branches 38292 38340 +48
========================================
+ Hits 175202 175519 +317
- Misses 12193 12212 +19
+ Partials 7551 7547 -4
🚀 New features to boost your workflow:
|
meixg
approved these changes
Aug 21, 2025
35 tasks
jasnell
reviewed
Aug 23, 2025
| This is the default behavior to maintain backward compatibility. | ||
| * `"cli"`: The executable can be launched with `--node-options="--flag1 --flag2"`, and those flags | ||
| will be parsed as execution arguments for Node.js instead of being passed to the user script. | ||
| This allows using arguments that are not supported by the `NODE_OPTIONS` environment variable. |
There was a problem hiding this comment.
Nit: it might be good to define "cli" in here very briefly.
There was a problem hiding this comment.
Did you mean defining the word "cli" as "command line interface"? I feel that for the target audience of this part of the documentation, that would be a bit superfluous - it seems unlikely that someone who is packaging an an application as a CLI SEA does not know what "cli" means.
jasnell
approved these changes
Aug 23, 2025
RaisinTen
approved these changes
Aug 24, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6722642 |
targos
pushed a commit
that referenced
this pull request
Aug 26, 2025
This implements the execArgvExtension configuration field for SEA, which takes one of three string values to specify whether and how execution arguments can be extended for the SEA at run time: * `"none"`: No extension is allowed. Only the arguments specified in `execArgv` will be used, and the `NODE_OPTIONS` environment variable will be ignored. * `"env"`: _(Default)_ The `NODE_OPTIONS` environment variable can extend the execution arguments. This is the default behavior to maintain backward compatibility. * `"cli"`: The executable can be launched with `--node-options="--flag1 --flag2"`, and those flags will be parsed as execution arguments for Node.js instead of being passed to the user script. This allows using arguments that are not supported by the `NODE_OPTIONS` environment variable. PR-URL: #59560 Fixes: #55573 Fixes: nodejs/single-executable#100 Refs: #51688 Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
joyeecheung
added
the
semver-minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the execArgvExtension configuration field for SEA, which takes one of three string values to specify whether and how execution arguments can be extended for the SEA at run time:
"none": No extension is allowed. Only the arguments specified inexecArgvwill be used, and theNODE_OPTIONSenvironment variable will be ignored."env": (Default) TheNODE_OPTIONSenvironment variable can extend the execution arguments. This is the default behavior to maintain backward compatibility."cli": The executable can be launched with--node-options="--flag1 --flag2", and those flags will be parsed as execution arguments for Node.js instead of being passed to the user script. This allows using arguments that are not supported by theNODE_OPTIONSenvironment variable.Refs: #51688
Fixes: #55573
Fixes: nodejs/single-executable#100